Fix ebook.de #3967
Fix ebook.de #3967
Conversation
stefan-kolb
force-pushed
the
fetcher-tests
branch
from
c61ca0c to
474cd91
Compare
stefan-kolb
added
the
status: ready-for-review
| try (InputStream stream = new BufferedInputStream(getURLForID(identifier).openStream())) { | ||
| List<BibEntry> fetchedEntries = getParser().parseEntries(stream); | ||
| try { | ||
| HttpResponse<String> response = Unirest.get(getURLForID(identifier).toString()).asString(); |
There was a problem hiding this comment.
Well, this now has the disdvantage that the Stream does not get closed. That's why try(....) is preferable.
There was a problem hiding this comment.
There is no Stream anymore?!
There was a problem hiding this comment.
Ah sorry, got confused by the diff.
Why is this ByteArrayInputStream needed? Is there no way to directly get the response with unirest?
There was a problem hiding this comment.
Caused by the interface
There was a problem hiding this comment.
Not sure whats better but we should stick to one: unirest vs our UrlDownloader
There was a problem hiding this comment.
We could directly use jsoup. We use that in dfiferent cases
There was a problem hiding this comment.
Jsoup is for a DOM that needs to be parsed. I don't need that here. I just need the body contents.
|
The ISBN fetcher tries ebook.de first and if no result is found, it switches to the chimbori/amazon fetcher. |
|
Yes. |
stefan-kolb
removed
the
status: ready-for-review
This reverts commit 02d12e5.
* upstream/master: (47 commits) Fix xmp exporter (#3964) Update JUnit from 5.2.0-M1 -> 5.2.0-RC1 Update xmlunit from 2.5.1 -> 2.6.0 Update mockito-core from 2.18.0 -> 2.18.3 Fixieee (#3970) Fix IEEE Fetcher by enabling cookie support (#3968) Update flowless from 0.6 -> 0.6.1 Update wiremock from 2.16.0 -> 2.17.0 Fix ebook.de (#3967) LOC test #3854 Fix arxiv tests New translations JabRef_en.properties (French) (#3963) Upgrade modernizer plugin New Crowdin translations (#3962) Fix test Improve test New Crowdin translations (#3961) New translations JabRef_en.properties (French) (#3960) Remove brackets before checking equality Replace all IEEE URLs with https #3930 (#3944) ... # Conflicts: # build.gradle # src/main/java/org/jabref/gui/BasePanel.java # src/main/java/org/jabref/gui/actions/CleanupAction.java # src/main/java/org/jabref/gui/collab/ChangeScanner.java # src/main/java/org/jabref/gui/exporter/ExportAction.java # src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditorViewModel.java # src/main/java/org/jabref/gui/openoffice/DetectOpenOfficeInstallation.java # src/main/java/org/jabref/gui/openoffice/OpenOfficeSidePanel.java # src/main/java/org/jabref/gui/preftabs/PreferencesDialog.java
Refs #3854
Unfortunately not a very clean fix, but it is fine again.
Using the normal InputStream does not return anything. Probably as it is detected as automated crawler?
The interface with InputStream is just not really fitting here.