Install profile #170

rosiel · 2021-12-13T19:53:23Z

This PR updates the demo box to be built using islandora-sandbox, which uses the islandora_install_profile_demo. Part of Islandora-Devops/isle-dc#160

…ildkit into install-profile

rosiel · 2021-12-13T19:59:48Z

Once sandbox (Islandora-Devops/islandora-sandbox#5) gets merged, we could update the instructions for which commit to pull down. At the very least, I'd be in favour of updating it to pull from islandora-devops not dannylamb.

drupal/rootfs/usr/local/bin/install-drupal-site.sh

drupal/rootfs/etc/islandora/utilities.sh

nigelgbanks

Aside from the password concern, everything else looks good. I'll try doing some testing tomorrow.

nigelgbanks · 2021-12-13T20:36:10Z

Once sandbox (Islandora-Devops/islandora-sandbox#5) gets merged, we could update the instructions for which commit to pull down. At the very least, I'd be in favour of updating it to pull from islandora-devops not dannylamb.

You can change it right now Dannys repo just forwards to Islandora-Devops atm.

rosiel · 2021-12-14T14:45:47Z

Changed the repos...

I'm not sure why it's printing passwords... is it just letting you know that the password for the container you just built is the thing you set it as in the file in buildkit?

nigelgbanks · 2021-12-17T13:53:25Z

Tried testing this today with isle-dc though it looks like some aspect of Drush has changed?

nigelgbanks · 2021-12-17T13:56:52Z

I'm not sure why it's printing passwords... is it just letting you know that the password for the container you just built is the thing you set it as in the file in buildkit?

echo goes to stdout and that all gets captured by Docker logs, I'll just remove those lines as part of testing. The user of isle-dc can change the file on disk for the password, or there could be an isle-dc command or last step that prints passwords out. It's just that it's not only isle-dc that consumes these images some people are running in ECS/Kubernetes etc and for them they wouldn't want their administrative passwords going into a log aggregator.

nigelgbanks · 2021-12-17T15:56:34Z

Sorry for taking a while to get around to this @rosiel, I've raised a pull request that fixes the merge conflict with main and brings in the changes from main into this branch. Also remove the spots where passwords would be printed out.

#177

I really tried to test it with isle-dc in particular with this branch: Islandora-Devops/isle-dc#160

But it was failing and I wasn't able to sort out why. So I've not actually been able to test the changes for the install profile.

* Fix logging errors with cantaloupe due to find/replace bug (#165) * Adding max_input_vars to php.ini (#166) * Explain how Docker Hub factors in the workflow. (#171) * Updated the introduction to redirect users to better starting points in case they ended up at this repo by accident. (#164) * [issue-172] Use explicit commits in URLs such that (#176) Code can change when pulling from a master branch, which causes checksum checks to fail. This can changes master to instead refer to explicit commits hashes. The output docker images is byte for byte the same though. * Prevent passwords from being logged. Co-authored-by: dannylamb <[email protected]> Co-authored-by: Rosie Le Faive <[email protected]>

rosiel · 2022-01-06T13:39:31Z

@nigelgbanks thanks for the review! The demo/Dockerfile is still conflicting, but we want to remove all those extra commands from that Dockerfile, right?

nigelgbanks · 2022-01-13T17:06:23Z

@rosiel Yup, I just merged main to get rid of them. I tested with https://github.com/Islandora-Devops/isle-dc/tree/install-profile but it doesn't seem to work with make demo.

log.txt

I also tried make demo-install-profile which finished running but the site was missing content and kinda broken.

rosiel · 2022-01-13T17:28:13Z

missing content: yes, that's the plan for the moment because we dont' have a way of putting default content in. @Natkeeran was working on a method using Workbench.
Kinda broken: yes. That's not buildkit's fault as far as I can see.

make demo doesn't work? oh dear. I'm not sure what to do about that. @dannylamb ?

…w reuse... (#179) * Refactor how we set/restore ownership of drupal settings file to allow reuse in containers based on this one. * Clarify comment. * Adjustments.

* Fix logging errors with cantaloupe due to find/replace bug (#165) * Adding max_input_vars to php.ini (#166) * Explain how Docker Hub factors in the workflow. (#171) * Updated the introduction to redirect users to better starting points in case they ended up at this repo by accident. (#164) * [issue-172] Use explicit commits in URLs such that (#176) Code can change when pulling from a master branch, which causes checksum checks to fail. This can changes master to instead refer to explicit commits hashes. The output docker images is byte for byte the same though. * Prevent passwords from being logged. Co-authored-by: dannylamb <[email protected]> Co-authored-by: Rosie Le Faive <[email protected]>

nigelgbanks · 2022-03-16T12:38:59Z

Just to put a note here, I'm working on automating the deployment of the sandbox and will update this with the output of that work once complete.

misilot · 2022-03-24T20:30:45Z

With the merge of Islandora-Devops/isle-dc#160 does this need to be merged, and a new version released?

Or would we just reference TAG 211bfffb9679221dee76562b699d7ae61cbabc86 ?

nigelgbanks · 2022-03-27T20:41:47Z

@misilot you can reference 211bfffb9679221dee76562b699d7ae61cbabc86 for now, once this has been confirmed to work it will be merged.

misilot · 2022-03-30T14:47:56Z

@rosiel any chance you could rebase this PR again? We ran into an issue with our system, so looking to test this again and stand up a new system.

misilot · 2022-03-30T20:34:51Z

@nigelgbanks do we need to update the TAG in isle-dc with this version? Since it is referencing the old (before rebasing) version currently

DonRichards · 2022-03-31T15:23:46Z

I tested the tag 211bfffb9679221dee76562b699d7ae61cbabc86 and it fails with make up, make local and make demo-install-profile. I wasn't able to find the tag within the list on Docker hub. I'm probably looking at the wrong place.

What did work for me

Switching TAG to 1.0.0-alpha-15 and DRUPAL_INSTALL_PROFILE to standard or minimal.

Is this something we can fix quickly or should we kinda revert isle-dc's sample.env defaults so that this builds properly by default?

misilot · 2022-04-05T19:38:14Z

I am seeing the following when trying to build with TAG=211bfffb9679221dee76562b699d7ae61cbabc86

@DonRichards I see it here https://hub.docker.com/layers/drupal/islandora/drupal/211bfffb9679221dee76562b699d7ae61cbabc86/images/sha256-66d57d2bd486d8034d07d3b2ff9fc54e74ab4c455e3fa707cf668b61dfa7ee4e?context=explore (At least I assume this is the same?)

 [error]  Config search_api.server.default_solr_server does not exist
 [error]  Config search_api.server.default_solr_server does not exist
make[1]: [Makefile:155: update-config-from-environment] Error 1 (ignored)
WARNING: Some services (activemq, alpaca, blazegraph, cantaloupe, crayfits, drupal, fcrepo, fits, homarus, houdini, hypercube, mariadb, matomo, milliner, recast, solr, traefik) use the 'deploy' key, which will be ignored. Compose does not support 'deploy' configuration - use `docker stack deploy` to deploy to a swarm.

In SolrCommandHelper.php line 119:

  Unknown server default_solr_server




ERROR: Could not generate SOLR config.zip!
In Drupal, check Configuration -> Search API -> SOLR Server, and use the
+ Get config.zip option which should give you information into the actual error.


make[1]: *** [Makefile:167: solr-cores] Error 1
make[1]: Leaving directory '/klib/app/docker-compose/isle-dc'
make: *** [Makefile:390: local-install-profile] Error 2

nigelgbanks · 2022-04-13T22:05:39Z

I've rebased and raised #209 using the latest commit from the sandbox in hopes to solve the make demo issues on Islandora-Devops/isle-dc#248 to get isle-dc into a working state.

dannylamb added 12 commits April 13, 2021 16:39

Updating sandbox commit

2bd3669

Trying to pull in the install profile

1f86ff8

Using install profile variable when installing Drupal with Drush

6b7f0ff

Bumping sandbox commit

2fc70cf

Setting content sync directory

9313caa

Fixing content_sync directories

bda0981

Bumping islandora-sandbox

69c9f9d

Bumping sandbox again

91f2b37

Merging in upstream

c2d65ae

Updating sandbox hash

21a732e

Merge branch 'main' into install-profile

5205186

Merge branch 'install-profile' of github.com:Islandora-Devops/isle-bu…

4f16354

…ildkit into install-profile

rosiel mentioned this pull request Dec 13, 2021

Install profile Islandora-Devops/isle-dc#160

Merged

nigelgbanks reviewed Dec 13, 2021

View reviewed changes

drupal/rootfs/usr/local/bin/install-drupal-site.sh Outdated Show resolved Hide resolved

nigelgbanks reviewed Dec 13, 2021

View reviewed changes

drupal/rootfs/etc/islandora/utilities.sh Outdated Show resolved Hide resolved

nigelgbanks reviewed Dec 13, 2021

View reviewed changes

Update commit for islandora-sandbox and use official repo.

aed5adc

Merge branch 'main' into install-profile

b07d96f

jasonhildebrand and others added 2 commits January 13, 2022 23:07

Refactor how we set/restore ownership of drupal settings file to allo…

78e2348

…w reuse... (#179) * Refactor how we set/restore ownership of drupal settings file to allow reuse in containers based on this one. * Clarify comment. * Adjustments.

Added LDAP extension to nginx/php image. (#181)

25edadb

jasonhildebrand and others added 13 commits February 1, 2022 16:18

If SOLR config.zip cannot be produced, show useful error message. (#182)

a65eb49

Updating sandbox commit

b8de904

Trying to pull in the install profile

8afd7be

Using install profile variable when installing Drupal with Drush

fac6648

Bumping sandbox commit

27fea4b

Setting content sync directory

598e9aa

Fixing content_sync directories

c55ad3f

Bumping islandora-sandbox

7cf1172

Bumping sandbox again

4b52d5b

Updating sandbox hash

2b69382

Update commit for islandora-sandbox and use official repo.

168d030

Rebase onto main.

211bfff

g7morris added isle-dc drupal docker-compose labels Mar 14, 2022

misilot mentioned this pull request Apr 5, 2022

Fix the TAG/DRUPAL_INSTALL_PROFILE Islandora-Devops/isle-dc#244

Merged

nigelgbanks closed this Apr 13, 2022

nigelgbanks deleted the install-profile branch April 19, 2022 09:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Install profile #170

Install profile #170

rosiel commented Dec 13, 2021

rosiel commented Dec 13, 2021

nigelgbanks left a comment

nigelgbanks commented Dec 13, 2021

rosiel commented Dec 14, 2021

nigelgbanks commented Dec 17, 2021

nigelgbanks commented Dec 17, 2021

nigelgbanks commented Dec 17, 2021

rosiel commented Jan 6, 2022

nigelgbanks commented Jan 13, 2022

rosiel commented Jan 13, 2022

nigelgbanks commented Mar 16, 2022

misilot commented Mar 24, 2022 •

edited

Loading

nigelgbanks commented Mar 27, 2022 •

edited

Loading

misilot commented Mar 30, 2022

misilot commented Mar 30, 2022 •

edited

Loading

DonRichards commented Mar 31, 2022 •

edited

Loading

misilot commented Apr 5, 2022

nigelgbanks commented Apr 13, 2022

Install profile #170

Install profile #170

Conversation

rosiel commented Dec 13, 2021

rosiel commented Dec 13, 2021

nigelgbanks left a comment

Choose a reason for hiding this comment

nigelgbanks commented Dec 13, 2021

rosiel commented Dec 14, 2021

nigelgbanks commented Dec 17, 2021

nigelgbanks commented Dec 17, 2021

nigelgbanks commented Dec 17, 2021

rosiel commented Jan 6, 2022

nigelgbanks commented Jan 13, 2022

rosiel commented Jan 13, 2022

nigelgbanks commented Mar 16, 2022

misilot commented Mar 24, 2022 • edited Loading

nigelgbanks commented Mar 27, 2022 • edited Loading

misilot commented Mar 30, 2022

misilot commented Mar 30, 2022 • edited Loading

DonRichards commented Mar 31, 2022 • edited Loading

What did work for me

misilot commented Apr 5, 2022

nigelgbanks commented Apr 13, 2022

misilot commented Mar 24, 2022 •

edited

Loading

nigelgbanks commented Mar 27, 2022 •

edited

Loading

misilot commented Mar 30, 2022 •

edited

Loading

DonRichards commented Mar 31, 2022 •

edited

Loading