Adding max_input_vars to php.ini #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigelgbanks
approved these changes
Nov 30, 2021
|
🙇 thanks Nigel |
rosiel
added a commit
that referenced
this pull request
Jan 5, 2022
* Fix logging errors with cantaloupe due to find/replace bug (#165) * Adding max_input_vars to php.ini (#166) * Explain how Docker Hub factors in the workflow. (#171) * Updated the introduction to redirect users to better starting points in case they ended up at this repo by accident. (#164) * [issue-172] Use explicit commits in URLs such that (#176) Code can change when pulling from a master branch, which causes checksum checks to fail. This can changes master to instead refer to explicit commits hashes. The output docker images is byte for byte the same though. * Prevent passwords from being logged. Co-authored-by: dannylamb <[email protected]> Co-authored-by: Rosie Le Faive <[email protected]>
rosiel
added a commit
that referenced
this pull request
Feb 10, 2022
* Fix logging errors with cantaloupe due to find/replace bug (#165) * Adding max_input_vars to php.ini (#166) * Explain how Docker Hub factors in the workflow. (#171) * Updated the introduction to redirect users to better starting points in case they ended up at this repo by accident. (#164) * [issue-172] Use explicit commits in URLs such that (#176) Code can change when pulling from a master branch, which causes checksum checks to fail. This can changes master to instead refer to explicit commits hashes. The output docker images is byte for byte the same though. * Prevent passwords from being logged. Co-authored-by: dannylamb <[email protected]> Co-authored-by: Rosie Le Faive <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a client site with a lot of fields (like 150+), forms for changing display and form modes started to have their ajax fail. When trying to do something that triggers AJAX like hiding a field in a display mode, you'll get an infinite spinning wheel. This is b/c you'll bump up against the limit of how large form POSTs are allowed to get.
This PR fixes the issue by letting you configure the
max_input_varsconfiguration for PHP and sets the default to something reasonably high so most people won't have to mess with this.