-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing initial install options #248
Conversation
Everything except [notice] Performed install task: install_settings_form
[notice] Performed install task: install_verify_database_ready
[notice] Performed install task: install_base_system
[notice] Performed install task: install_bootstrap_full
[notice] Performed install task: install_profile_modules
[notice] Performed install task: install_profile_themes
[notice] Performed install task: install_install_profile
[notice] Performed install task: install_configure_form
[notice] Performed install task: install_finished
[success] Installation complete.
make[1]: Leaving directory '/home/don/github/isle-dc'
In PmCommands.php line 316:
Unable to install modules search_api_solr_defaults, islandora_defaults due
to missing modules islandora_defaults.
make: *** [Makefile:355: local] Error 1 |
2022/04/07 21:49:46 [error] 1080#1080: *10 FastCGI sent in stderr: "PHP message: Uncaught PHP Exception Drupal\Core\Config\UnmetDependenciesException: "Configuration objects provided by islandora_base_theme have unmet dependencies: block.block.islandora_base_theme_branding (islandora_install_profile_demo_core), block.block.islandora_base_theme_breadcrumbs (islandora_install_profile_demo_core, block_class), block.block.islandora_base_theme_disclaimer (fixed_block_content), field.storage.block_content.field_carapace_cb_copyright (field_permissions)" at /var/www/drupal/web/core/lib/Drupal/Core/Config/UnmetDependenciesException.php line 100" while reading response header from upstream, client: 172.26.0.3, server: drupal, request: "GET /admin/appearance/default?theme=islandora_base_theme&token=Jxm5tr4UYprzMZe97IIJv99SqXFrXugmhWiOBpdMwqQ HTTP/1.1", upstream: "fastcgi://unix:/var/run/php-fpm7/php-fpm7.sock:", host: "islandora.traefik.me", referrer: "https://islandora.traefik.me/admin/appearance" |
This is so convoluted to update. Once this is approved, these two lines will have to be changed before accepting the 3 PRs together: And the custom branch needs to be removed from this line As per my previous statement, I pulled Testing: I am getting a |
@noahwsmith I pulled your latest changes (66bd09f) and just tried running on macOS Big Sur Hope this help a bit. |
Notes:
Will try and test the others in a bit. |
testing make local-install-profile now. |
Local install profile worked perfectly, in as far as completed the build without fatal errors. The certificate expired on the 8th, but other than that looks good. Taxonomy terms are all in place, solr is wired and responsive, and the page not found message disappears when you build a basic page. But http://islandora.traefik.me:8081/fcrepo/ gives bad gateway whether from the browser or curled from inside the container. The system will not allow an image to be uploaded, possibly related to
Update: certs no longer a problem, but build is not usable without a Fedora connection |
I did see the following when
Same, I am seeing the 502's on there and the following errors: activemq
alpaca
fcrepo
mariadb
milliner
|
Looking at the issues backlog, I think this has fixed it. I've pulled it into this branch and retested with cc @dannylamb and @nigelgbanks who were working on that. So I think this addresses a bunch of issues I'm hearing on the isle slack about alpha-15 not booting. I'll leave a note there too... Any takers for testing this? Thanks for all the confirmations earlier... |
@noahwsmith I was able to run Drupal loaded fine without errors. THere were no items that had been ingested, but I was able to ingest an image. I also visited the Fedora rest page and I can see new objects created after my ingest. I will try building the UPDATE 1: I was able to run UPDATE 2: I was able to run |
Testing Update: I've got two prod boxes I'm going to build real fast before it changes its mind. |
Ugh. On a prod install we're back to this
|
@noahwsmith I wanted to add more details about running I was not able to create a "repository item." I was getting a white page with the following error “The website encountered an unexpected error. Please try again later.” In the Drupal recent log messages section I saw this two errors...
and...
|
The offending lines in a fresh build on an Ubuntu box
Complete success with a build on my Mac last night. UPDATE!! I was able to build without changing anything. I'm going to blame some caching on my server. |
I was just talking to Nigel and he's going to test this now too. Sounds like |
I did find the use case for https://islandora.github.io/documentation/installation/docker-demo/ |
Demo is a bit messed up, it initially looks good though, but I've ran into a few issues. The search display doesn't return results, but I checked the solr index and the content has been indexed correctly I think the view might be a bit messed up. Trying to create
|
|
Ok, I thought it was mentioned it was being removed. |
@misilot I didn't know, I thought it was different than |
It takes a long time to test on the mac due to the bind mount volumes and install is like 30-40 mins to bring up a fresh one. |
Going back to
This makes sense cause it's not installed in |
Pushed some changes to update the commits to pull the latest, though
I'll dig in more tomorrow. |
|
Looks like there is an infinite recursion in In particular it's the Manually generating the hash table gets around this issue, in attempting to test with new objects for this infinite loop, I've encountered a new issue.
The file does not exist.
Also lots of these:
Field comes from a contrib module Attempting to run updb to hopefully add that column results in the following errors.
I ignored the errors and ran it anyways, I did not resolve the issue. In reading through the modules code when it goes to define and add the fields to an entity it does a check. if (!$this->hasAuthor()) {
$definitions['content_translation_uid'] = BaseFieldDefinition::create('entity_reference')
->setLabel(t('Translation author'))
->setDescription(t('The author of this translation.'))
->setSetting('target_type', 'user')
->setSetting('handler', 'default')
->setRevisionable(TRUE)
->setDefaultValueCallback(static::class . '::getDefaultOwnerId')
->setTranslatable(TRUE);
} Which makes sense to avoid the extra field if not necessary. No this does not seem to be the case (it's actually a core module, and this logic has not changed really in 7 years...) More oddities:
The default theme is not installed, attempting to install it causes a whitescreen.
|
Sorry, I think I misunderstood some of the previous comments. I think the
Mariadb is showing some errors as Access denied for user drupal_default. Other errors on MariaDB were aborted unauthenticated user from matomo, drupal, and fedora for the make demo & local commands. |
Ok, so the task here/now is to rebase this and fix |
@noahwsmith Yes. I just spoke with Danny and we hatched out a plan.
|
6d2723c
to
296e1a5
Compare
OK, complete. @ajstanley Would you be interested in testing? I removed the "demo-install-profile & local-install-profile" as commands. They replaced the default demo and local. To test just run |
Building now - |
make local gave the usual
But worked (with the collection caveat mentioned above) Nice work all! |
@ajstanley Yeah, not sure why that's complaining but it does seem to be building correctly. If you're satisfied with this as well I'll leave it up to you to "approve & merge" because I contributed to the code. |
^ Thanks @DonRichards and @ajstanley for seeing this across the line... |
Is this totally fine? Because I am getting errors on |
In the Starter Site, we have these explained: https://github.com/Islandora-Devops/islandora-starter-site#warningserrors-during-installation An FYI, we're encouraging people to install the starter site rather than the install profile as the Install Profile is about to be deprecated. That would be the Feel free to join the Slack workspace and post in |
This MR addresses the issues raised in #244 and other places regarding upstream changes breaking the
make local_install_profile_demo
command.To test this MR, please check:
make local
make demo
make local_install_profile_demo
For bonus points I guess also
make demo_install_profile_demo
but I sort of think we should pull that out, I don't really see the use for it, honestly.The
install_profile
commands will fail until this is accepted - it's the root cause of most of the issues. Islandora_defaults changed a storage type, and we're just now catching up to it, I guess...Islandora-Devops/islandora_install_profile_demo#16