Errors can occur during CR status update

[phlg]

In v0.8.0 on the operator, the reconcile loop can generate some errors when trying to update the status of a resource. Due to requeuing, the operator eventually reaches green status, but the error itself is jarring. Example for a policy :

2024-02-29T14:28:04.452Z  INFO  s3Client  retrieving policy info  {"policy": "dummy-policy"}
2024-02-29T14:28:04.477Z  INFO  s3Client  the policy does not exist {"policy": "dummy-policy"}
2024-02-29T14:28:04.477Z  INFO  s3Client  create or update policy {"policy": "dummy-policy"}
2024-02-29T14:28:04.541Z  INFO  s3Client  retrieving policy info  {"policy": "dummy-policy"}
2024-02-29T14:28:04.541Z  INFO  policyEventFilter reconcile update event is filtered out  {"resource": "policy-dummy-policy"}
2024-02-29T14:28:04.550Z  INFO  s3Client  create or update policy {"policy": "dummy-policy"}
2024-02-29T14:28:04.581Z  ERROR an error occurred while updating the status of the policy resource  {"controller": "policy", "controllerGroup": "s3.onyxia.sh", "controllerKind": "Policy", "Policy": {"name":"policy-dummy-policy","namespace":"s3-resources"}, "namespace": "s3-resources", "name": "policy-dummy-policy", "reconcileID": "xxx", "error": "Operation cannot be fulfilled on policies.s3.onyxia.sh \"policy-dummy-policy\": the object has been modified; please apply your changes to the latest version and try again"}
github.com/InseeFrLab/s3-operator/controllers.(*PolicyReconciler).SetPolicyStatusConditionAndUpdate
  /workspace/controllers/policy_controller.go:274
github.com/InseeFrLab/s3-operator/controllers.(*PolicyReconciler).Reconcile
  /workspace/controllers/policy_controller.go:171
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
  /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:119
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
  /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:316
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
  /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
  /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:227
2024-02-29T14:28:04.582Z  ERROR Reconciler error  {"controller": "policy", "controllerGroup": "s3.onyxia.sh", "controllerKind": "Policy", "Policy": {"name":"policy-dummy-policy","namespace":"s3-resources"}, "namespace": "s3-resources", "name": "policy-dummy-policy", "reconcileID": "e0cd9979-c85f-4534-bad8-80f31926b7bc", "error": "Operation cannot be fulfilled on policies.s3.onyxia.sh \"policy-dummy-policy\": the object has been modified; please apply your changes to the latest version and try again", "errorCauses": [{"error": "Operation cannot be fulfilled on policies.s3.onyxia.sh \"policy-dummy-policy\": the object has been modified; please apply your changes to the latest version and try again"}]}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
  /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:329
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
  /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
  /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:227
2024-02-29T14:28:04.587Z  INFO  s3Client  retrieving policy info  {"policy": "dummy-policy"}
2024-02-29T14:28:04.609Z  INFO  policyEventFilter reconcile update event is filtered out  {"resource": "policy-dummy-policy"}

This is most likely due to a poorly implemented change in the EventFilter logic in #40. In which case, the fix could be either to :

• change that EventFilter (maybe finding a way to use lastTransitionTime after all ?)
• change the reconcile loop to avoid these failures with the new EventFilter, if it's considered sane enough (of which I am pretty much unsure)