Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage resource deletion and event filtering, fix imports #40

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

phlg
Copy link
Contributor

@phlg phlg commented Feb 28, 2024

  • Adds three flags to toggle resource deletion on the S3 backend. Caveats :
    • Bucket deletion will fail if not empty
    • Path deletion only removes the .keep file, not everything matching the path as a prefix
    • The account used to run the operator must have the necessary rights (s3:DeleteBucket, s3:DeleteObject, admin:DeletePolicy)
  • Changes the event filtering logic, see comments in any of the controller for details
  • Fix the imports incorrectly referencing a fork under my personal GH namespace

@phlg phlg self-assigned this Feb 28, 2024
@phlg phlg merged commit 2058167 into main Feb 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant