Fix event filters (#41), lastTransitionTime not updated in conditions, and path finalize #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as a PR to fix #41 (through a rollback of the changes to event filtering introduced in v0.8.0), but has some extras :
meta.SetStatusCondition()
, as the way we use conditions in this operator does not fit well with the way that function works (mostly, it doesn't updatelastTransitionTime
if a new generation of CR implies re-obtaining a condition that the CR was previously in). We did this in a basic & naive implementation in a separateutils.go
created for the occasion. Can probably be upgraded.