Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event filters (#41), lastTransitionTime not updated in conditions, and path finalize #42

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

phlg
Copy link
Contributor

@phlg phlg commented Mar 6, 2024

This started as a PR to fix #41 (through a rollback of the changes to event filtering introduced in v0.8.0), but has some extras :

  • Does away with meta.SetStatusCondition(), as the way we use conditions in this operator does not fit well with the way that function works (mostly, it doesn't update lastTransitionTime if a new generation of CR implies re-obtaining a condition that the CR was previously in). We did this in a basic & naive implementation in a separate utils.go created for the occasion. Can probably be upgraded.
  • The recently added Finalizer management did not work well for paths. If a Path CR was created with a wrong spec (eg : on a non-existing bucket), then then actual path does not exist on the S3 backend, and the finalizePath() function chokes on this. It was reworked to actively check for path existence prior to attempting deletion.

phlg added 2 commits March 5, 2024 16:42
- rollback event filter changes
- reimpl. of Set*StatusConditionAndUpdate functions (w/ new utils.go)
- unify loggers in reconcile loop
@phlg phlg self-assigned this Mar 6, 2024
@phlg phlg linked an issue Mar 6, 2024 that may be closed by this pull request
@phlg phlg merged commit 9ef45a3 into main Mar 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors can occur during CR status update
1 participant