Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Minimum Virus": Please Support 1.22 Without Patch Version Requirement #133

Closed
majew7 opened this issue Jan 22, 2025 · 3 comments · Fixed by #134
Closed

"Minimum Virus": Please Support 1.22 Without Patch Version Requirement #133

majew7 opened this issue Jan 22, 2025 · 3 comments · Fixed by #134
Labels
bug Something isn't working

Comments

@majew7
Copy link

majew7 commented Jan 22, 2025

Please direct all support questions to slack or the forums. Thank you.

ISSUE Described

On Nov 11, 2024, influxdb3-go began requiring a minimum of Go v1.22.7, and even a toolchain minimum of v1.22.9.

kaovilai writes:

This repo by itself should not be enforcing minimum on other repositories importing it. Stop spreading "minimum virus"

The issue is that our team must now make too many changes on our side unnecessarily, including CI.

Context: An Story of Unlucky Timing

Conclusion: I think influxdb3-go go upgraded right before grpc-go dropped their minimum version back down to Gov1.22. If Influx had waited ~24 hours, the "minimum virus" wouldn't have formed.

Version Request

  1. Would you please reduce the minimum Go version just as grpc-go did on Nov 12, 2024?
  2. Would you please drop the toolchain directive, unless it's necessary?
@bednar
Copy link
Member

bednar commented Jan 22, 2025

Hi @majew7,

Thank you for reporting this.

All your requirements are reasonable. Are you able to create a PR for this? I can review it quickly.

Best regards

@bednar bednar added the bug Something isn't working label Jan 22, 2025
@majew7
Copy link
Author

majew7 commented Jan 22, 2025

Thanks for your reply Bednar!

I would, unfortunately, my company cannot commit to OSS w/o obtaining approval from legal first. Thus another Influx community member would need to initiate it.

@bednar
Copy link
Member

bednar commented Jan 22, 2025

@majew7, it’s okay. I’ve prepared this PR: #134. Can you please take a look and leave comments if it works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants