Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod patch version is forcing toolchain, breaking builds. #1188

Closed
matthewhartstonge opened this issue Feb 11, 2025 · 8 comments
Closed

go.mod patch version is forcing toolchain, breaking builds. #1188

matthewhartstonge opened this issue Feb 11, 2025 · 8 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@matthewhartstonge
Copy link

matthewhartstonge commented Feb 11, 2025

Hi Team,

I noticed that RenovateBot added a patch released that pushed minimum requirements of Go up to 1.22.11. This patch version was introduced via revonatebot #1185

This has ended up proliferating through the API SDKs and breaking CI/dependency upgrade builds.

Can the version requirement be relaxed to 1.22 to remain compatible with Go's version guarantees.

Environment details

  • Programming language: Golang
  • OS: macOS
  • Language runtime version: latest

Steps to reproduce

  1. update google.golang.org/api from 0.219.0 to 0.220.0

Version Request

Related/Relevant Issues
@matthewhartstonge matthewhartstonge added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 11, 2025
@quartzmo
Copy link
Member

Related to googleapis/google-cloud-go#11468.

@matthewhartstonge
Copy link
Author

Ahh sorry @quartzmo - I had a sift through open issues before filing.
Was 3-4 repos deep finding the culprit and missed the issue in this repo 🙈

@quartzmo
Copy link
Member

@matthewhartstonge It was good that you opened these issues. 11468 is for the root problem (Renovate), but we still need to discover and fix these leaf issues as well.

@quartzmo
Copy link
Member

Attempting to remove toolchain and downgrade go to 1.22, I get this error:

➜  go-genproto git:(main) ✗ go1.22.0 mod tidy
go: cloud.google.com/go/[email protected] requires go >= 1.22.7 (running go 1.22.0; GOTOOLCHAIN=local)

quartzmo added a commit to quartzmo/go-genproto that referenced this issue Feb 11, 2025
@liggitt
Copy link
Contributor

liggitt commented Feb 11, 2025

Yeah, it's viral, have to unwind in all dependencies before you can roll it back here.

@quartzmo
Copy link
Member

@liggitt Do you know anything about any effort to unwind this in Open Telemetry? Is there an existing issue?

@liggitt
Copy link
Contributor

liggitt commented Feb 12, 2025

I do not, sorry

@codyoss
Copy link
Member

codyoss commented Feb 12, 2025

@quartzmo I think we have several of this issues. Can we consolidate all the threads down to one issue. It would be nice to keep the conversation all in one place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

4 participants