Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Minimum Virus": go.mod should support 1.2x without patch version, or 1.2x.0 #3009

Open
matthewhartstonge opened this issue Feb 11, 2025 · 8 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@matthewhartstonge
Copy link

matthewhartstonge commented Feb 11, 2025

Hi Team,

I noticed that RenovateBot added a patch released that pushed minimum requirements of Go up to 1.22.11. This patch version was introduced via revonatebot https://github.com/googleapis/google-api-go-client/pull/2992/files due to googleapis/go-genproto#1185

This has ended up proliferating through the API SDKs and breaking CI/dependency upgrade builds.

Can the version requirement be relaxed to 1.22 to remain compatible with Go's version guarantees.

Environment details

  • Programming language: Golang
  • OS: macOS
  • Language runtime version: latest

Steps to reproduce

  1. update google.golang.org/api from 0.219.0 to 0.220.0

Version Request

Related/Relevant Issues
@matthewhartstonge matthewhartstonge added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 11, 2025
@codyoss codyoss assigned quartzmo and unassigned codyoss Feb 11, 2025
@quartzmo
Copy link
Member

Related to googleapis/google-cloud-go#11468.

@quartzmo
Copy link
Member

@matthewhartstonge PTAL at PR #3011, which demonstrates a dependency issue that may be blocking us from making this fix. Would like to get your input, please comment on the PR.

@matthewhartstonge

This comment has been minimized.

@quartzmo
Copy link
Member

@matthewhartstonge Do you know why the minimum in this repo is 1.22.7, while the otel minimum is 1.22.0? If not, I'll try to investigate.

@matthewhartstonge
Copy link
Author

yarp, essentially what you found in #3011 due to go: cloud.google.com/go/[email protected] requires [email protected], but 1.22 is requested

@quartzmo quartzmo changed the title go.mod patch version is forcing toolchain, breaking builds "Minimum Virus": go.mod should support 1.2x without patch version Feb 13, 2025
@quartzmo
Copy link
Member

Renamed this issue to reflect the focus on "Would you please drop the toolchain directive, unless it's necessary?", above. The toolchain removal request is already covered by googleapis/google-cloud-go#11468.

@quartzmo
Copy link
Member

Note that opentelemetry-go reduced its version to 1.22.0 in Release v1.34.0/v0.56.0/v0.10.0 open-telemetry/opentelemetry-go#6073

@quartzmo quartzmo changed the title "Minimum Virus": go.mod should support 1.2x without patch version "Minimum Virus": go.mod should support 1.2x without patch version, or 1.22.0 Feb 13, 2025
@quartzmo quartzmo changed the title "Minimum Virus": go.mod should support 1.2x without patch version, or 1.22.0 "Minimum Virus": go.mod should support 1.2x without patch version, or 1.2x.0 Feb 13, 2025
@quartzmo
Copy link
Member

Discussion of patch version in golang/go/issues/65847 issue about toolchain: golang/go#65847 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants