-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Minimum Virus": go.mod should support 1.2x without patch version, or 1.2x.0 #3009
Comments
Related to googleapis/google-cloud-go#11468. |
@matthewhartstonge PTAL at PR #3011, which demonstrates a dependency issue that may be blocking us from making this fix. Would like to get your input, please comment on the PR. |
This comment has been minimized.
This comment has been minimized.
@matthewhartstonge Do you know why the minimum in this repo is |
yarp, essentially what you found in #3011 due to |
Renamed this issue to reflect the focus on "Would you please drop the toolchain directive, unless it's necessary?", above. The toolchain removal request is already covered by googleapis/google-cloud-go#11468. |
Note that opentelemetry-go reduced its version to |
Discussion of patch version in golang/go/issues/65847 issue about toolchain: golang/go#65847 (comment) |
Hi Team,
I noticed that RenovateBot added a patch released that pushed minimum requirements of Go up to 1.22.11. This patch version was introduced via revonatebot https://github.com/googleapis/google-api-go-client/pull/2992/files due to googleapis/go-genproto#1185
This has ended up proliferating through the API SDKs and breaking CI/dependency upgrade builds.
Can the version requirement be relaxed to
1.22
to remain compatible with Go's version guarantees.Environment details
Steps to reproduce
Version Request
Related/Relevant Issues
The text was updated successfully, but these errors were encountered: