Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change codeSystem to use inactive as well as deprecated #24

Merged
merged 8 commits into from
Feb 8, 2024
Merged

change codeSystem to use inactive as well as deprecated #24

merged 8 commits into from
Feb 8, 2024

Conversation

JohnMoehrke
Copy link
Contributor

close #23
and cleanup new build warnings

@JohnMoehrke
Copy link
Contributor Author

https://build.fhir.org/ig/IHE/FormatCode/branches/moehrke-inactive/index.html

@JohnMoehrke
Copy link
Contributor Author

expansion doesn't include IHE codes. Removing inactive doesn't help. So this doesn't seem related. Grahame is looking at it.

JohnMoehrke
JohnMoehrke commented Feb 7, 2024
View reviewed changes
Copy link
Contributor Author

@JohnMoehrke JohnMoehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add provenance of valueSet change
  • remove commented out experiment in codeSystem

JohnMoehrke
JohnMoehrke commented Feb 7, 2024
View reviewed changes
Copy link
Contributor Author

@JohnMoehrke JohnMoehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add provenance of valueSet change
  • remove commented out experiment in codeSystem
  • add release json

@JohnMoehrke
Copy link
Contributor Author

would trigger a publication of a patch release level.

lukeaduncan
lukeaduncan approved these changes Feb 8, 2024
View reviewed changes
Copy link

@lukeaduncan lukeaduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

lukeaduncan
lukeaduncan approved these changes Feb 8, 2024
View reviewed changes
Copy link

@lukeaduncan lukeaduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@JohnMoehrke JohnMoehrke merged commit efebd9d into master Feb 8, 2024
@JohnMoehrke JohnMoehrke deleted the moehrke-inactive branch February 8, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeaduncan lukeaduncan lukeaduncan approved these changes

@oliveregger oliveregger oliveregger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

concept-property#inactive
3 participants
@JohnMoehrke @oliveregger @lukeaduncan