Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed ftol in favor of tol. Added it to leas squares to keep same f… #803

Merged
merged 3 commits into from
Jan 20, 2022

Conversation

PaulJonasJost
Copy link
Collaborator

removed ftol from script optimizer options as many solvers are not able to make use of it. Instead used tol.

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2022

Codecov Report

Merging #803 (523ab5b) into develop (160c2a8) will decrease coverage by 44.06%.
The diff coverage is 39.92%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #803       +/-   ##
============================================
- Coverage    88.16%   44.10%   -44.07%     
============================================
  Files           79      106       +27     
  Lines         5257     7269     +2012     
============================================
- Hits          4635     3206     -1429     
- Misses         622     4063     +3441     
Impacted Files Coverage Δ
pypesto/engine/mpi_pool.py 0.00% <0.00%> (ø)
pypesto/engine/task.py 100.00% <ø> (ø)
pypesto/objective/aesara.py 0.00% <0.00%> (ø)
pypesto/sample/adaptive_parallel_tempering.py 30.43% <0.00%> (-65.22%) ⬇️
pypesto/sample/auto_correlation.py 9.09% <0.00%> (-86.37%) ⬇️
pypesto/sample/diagnostics.py 23.07% <ø> (-46.16%) ⬇️
pypesto/sample/emcee.py 28.30% <ø> (ø)
pypesto/sample/geweke_test.py 14.08% <ø> (-80.29%) ⬇️
pypesto/sample/metropolis.py 26.31% <ø> (-71.06%) ⬇️
pypesto/sample/parallel_tempering.py 23.61% <ø> (-70.76%) ⬇️
... and 159 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b21b391...523ab5b. Read the comment docs.

Copy link
Member

@yannikschaelte yannikschaelte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change to tol: float = None in l. 270 too. @FFroehlich opinions?

@FFroehlich
Copy link
Contributor

I would change to tol: float = None in l. 270 too. @FFroehlich opinions?

sounds good

@PaulJonasJost PaulJonasJost merged commit c295407 into develop Jan 20, 2022
@PaulJonasJost PaulJonasJost mentioned this pull request Apr 8, 2022
@PaulJonasJost PaulJonasJost deleted the ftol_to_tol branch June 2, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants