Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scipy Optimizer trust-constr does not work #613

Closed
LeonardSchmiester opened this issue Mar 30, 2021 · 6 comments · Fixed by #1218
Closed

Scipy Optimizer trust-constr does not work #613

LeonardSchmiester opened this issue Mar 30, 2021 · 6 comments · Fixed by #1218
Assignees
Labels
fixed but not released optimization Related to optimization process

Comments

@LeonardSchmiester
Copy link
Member

Optimization with trust-constr from scipy does not work currently because the default options we set for scipy are not known to trust-constr. Therefore optimization stops with:

start 0 failed: _minimize_trustregion_constr() got an unexpected keyword argument 'max_nfev'

@yannikschaelte pointed out, that also for some other optimizer there are warnings regarding not supported options (see https://github.com/ICB-DCM/pyPESTO/runs/2225587545?check_suite_focus=true#step:6:1169)

@yannikschaelte
Copy link
Member

I think we'll want a more intelligent method-specific setting of hyperparameters.

@yannikschaelte
Copy link
Member

@LoosC , you here?

@elbaraim elbaraim assigned yannikschaelte and unassigned elbaraim Mar 30, 2021
@yannikschaelte yannikschaelte removed their assignment Mar 30, 2021
@FFroehlich
Copy link
Contributor

This is probably the result of scipy better harmonizing the optimization interfaces. Simply removing the specific mapping of maxiter to max_nfev for trust_constr should fix the issue.

@FFroehlich
Copy link
Contributor

maxiter/max_nfev appears to be fixed in #283 (about a year before this issue was posted?). I think the actual issue is ftol, which shouldn't be set with a default for trust-constr.

@yannikschaelte
Copy link
Member

@PaulJonasJost this should be related to #778

@PaulJonasJost
Copy link
Collaborator

@PaulJonasJost this should be related to #778

@yannikschaelte, @LeonardSchmiester could this perhaps have been fixed by #803?

@dweindl dweindl added the optimization Related to optimization process label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed but not released optimization Related to optimization process
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants