Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(input_label_visible): fix issues related to the Firefox css pseudo-element #2180

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Fix(input_label_visible): fix issues related to the Firefox css pseudo-element #2180

merged 2 commits into from
Feb 10, 2025

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Feb 3, 2025 •
edited by philljenkins
Loading

  • Rule bug: input_label_visible

This PR is related to the following issue(s):

Testing reference:

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

Assets to aide review attached

  • Links to design artifacts
  • Links to video walkthrough of user experience
  • Other - Action Artifact

Definition of Done

  • Peer review complete
  • Secondary review complete
  • Staging deployment verified

@philljenkins
Copy link
Contributor

@shunguo I tested in Firefox,
results are noted in the issue comments.
Ready for PR Review and to create a companion 4.x PR

@philljenkins philljenkins marked this pull request as ready for review February 5, 2025 17:25
philljenkins
philljenkins approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing in Firefox no longer triggers the false positive

@tombrunet tombrunet merged commit 786005b into master Feb 10, 2025
17 checks passed
@tombrunet tombrunet deleted the dev-2085 branch February 10, 2025 16:03
tombrunet added a commit that referenced this pull request Feb 10, 2025
@tombrunet @philljenkins @shunguoy
chore(archive): Create archive for Feb 10, 2025 for v4.x (#2198)
951f882 
* update the rule and add a test case #dev-2085 (#2180)

Co-authored-by: Phill Jenkins <[email protected]>

* fix(cypress-accessibility-checker) update links in ReadMe (#2188)

* fix URL

* fix all 404 links

---------

Co-authored-by: Tom Brunet <[email protected]>

* ACT errors with scIds (#2193)

* Generate summaries on close (#2196)

* chore(archive): Create archive for Feb 10, 2025

---------

Co-authored-by: Phill Jenkins <[email protected]>
Co-authored-by: Shunguo Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philljenkins philljenkins philljenkins approved these changes

@tombrunet tombrunet tombrunet approved these changes

Assignees

@philljenkins philljenkins

Labels
Ready for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix(input_label_visible) should not trigger when clipped 0,0,0,0 - different behavior in FF vs Chrome
3 participants
@shunguoy @philljenkins @tombrunet