Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cypress-accessibility-checker) update links in ReadMe #2188

Merged
merged 3 commits into from
Feb 10, 2025
Merged

fix(cypress-accessibility-checker) update links in ReadMe #2188

merged 3 commits into from
Feb 10, 2025

Conversation

philljenkins
Copy link
Contributor

@philljenkins philljenkins commented Feb 5, 2025 •
edited
Loading

  • Other (Provide information)
    • update links in ReadMe causing 404

This PR is related to the following issue(s):

Testing reference:

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

Assets to aide review attached

  • Links to design artifacts
  • Links to video walkthrough of user experience
  • Other

Definition of Done

  • Peer review complete
  • Secondary review complete
  • Staging deployment verified

@philljenkins philljenkins self-assigned this Feb 5, 2025
@philljenkins philljenkins requested a review from shunguoy February 5, 2025 20:32
@philljenkins philljenkins assigned shunguoy and unassigned philljenkins Feb 5, 2025
@tombrunet tombrunet merged commit 18c543a into master Feb 10, 2025
17 checks passed
tombrunet added a commit that referenced this pull request Feb 10, 2025
@tombrunet @philljenkins @shunguoy
chore(archive): Create archive for Feb 10, 2025 for v4.x (#2198)
951f882 
* update the rule and add a test case #dev-2085 (#2180)

Co-authored-by: Phill Jenkins <[email protected]>

* fix(cypress-accessibility-checker) update links in ReadMe (#2188)

* fix URL

* fix all 404 links

---------

Co-authored-by: Tom Brunet <[email protected]>

* ACT errors with scIds (#2193)

* Generate summaries on close (#2196)

* chore(archive): Create archive for Feb 10, 2025

---------

Co-authored-by: Phill Jenkins <[email protected]>
Co-authored-by: Shunguo Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shunguoy shunguoy shunguoy approved these changes

@tombrunet tombrunet tombrunet approved these changes

Assignees

@shunguoy shunguoy

Labels
Ready for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"File Not Found" displays for "achecker.js" noted in cypress-accessibility-checker README.md
3 participants
@philljenkins @shunguoy @tombrunet