Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(input_label_visible) should not trigger when clipped 0,0,0,0 - different behavior in FF vs Chrome #2085

Closed
1 task done
philljenkins opened this issue Nov 4, 2024 · 3 comments · Fixed by #2180 or #2187
Closed
1 task done
Assignees
Labels
Bug Something isn't working Carbon Carbon related issue engine Issues in the accessibility-checker-engine component Firefox When different than in Chrome T63

Comments

@philljenkins
Copy link
Contributor

philljenkins commented Nov 4, 2024

The Carbon Tab list does not trigger this rule in Chrome, but does in Firefox:

The SVG button is clipped 0,0,0,0 in this Carbon tab list buttons, so this rule should not be triggered:
See
https://react.carbondesignsystem.com/iframe.html?args=&id=components-tabs--default&viewMode=story

image

<button
    title="Remove Dashboard tab"
    class="cds--visually-hidden cds--tabs__nav-item--close-icon--selected"
    aria-hidden="true"
    tabindex="-1"
    type="button">

In Chrome, the style is
cds--tabs__nav-item--close--hidden {
clip: rect(0, 0, 0, 0);

In Firefox, the style is also:
.cds--tabs__nav-item--close--hidden {
clip: rect(0,0,0,0);

but, Firefox is warning:

clip is deprecated by W3C standards.
Learn more about clip

@philljenkins philljenkins added the Bug Something isn't working label Nov 4, 2024
@philljenkins
Copy link
Contributor Author

philljenkins commented Nov 4, 2024

This rule does not trigger in either Chrome or Firefox in store Version 3.1.76
only in Firefox using PR #2025 Action Artifact.

@philljenkins
Copy link
Contributor Author

This is an "Other related Issues possible for this release" in Epic #2100

@philljenkins philljenkins added Carbon Carbon related issue Firefox When different than in Chrome and removed priority-1 (high) labels Nov 15, 2024
@philljenkins
Copy link
Contributor Author

Using this test page
https://react.carbondesignsystem.com/iframe.html?args=&id=components-tabs--default&viewMode=story

After the fix, the Carbon element are correctly not triggered in Firefox

Image

Before the fix, the Checker incorrectly flagged the test page input elements as not having associated visible labels:

  • Rule ID: input_label_visible
  • Reason ID: potential_no_label
  • Needs review
  • The input element does not have an associated visible label
  • An input element must have an associated visible label
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Carbon Carbon related issue engine Issues in the accessibility-checker-engine component Firefox When different than in Chrome T63
Projects
None yet
3 participants