-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Create Topics #852
Conversation
Added preliminary support for create topics
[DATAENG-211] Topic creation fails
Merge upstream master changes
Does this create topics work only with kafka 0.11 or older versions as well ? Is this the new admin API that is done admin api ? Please confirm. previously create topics is done to zoo keeper directly. Now can that be done with kafka directly using sarama ? |
This uses the create topics request introduced in 0.10.1.0. See https://cwiki.apache.org/confluence/display/KAFKA/KIP-4+-+Command+line+and+centralized+administrative+operations. |
Is this PR out of scope for sarama or is there something I could help with here? |
Hi @fgeller I added this PR when I was working with Kafka. I have been on a new project the past 4 months. It would be great if this could be merged into Sarama. I think it needs more tests and testing. We had not tested it across various versions and scenarios. I don't think it is out of scope but I haven't been following Sarama since June. |
Ya, sorry I never got around to looking at this properly. I'd be happy to accept something along these lines into Sarama, with a few comments on the specific code here:
|
@fgeller please go ahead. I don't have the time right now to work on this. Thank you for taking this up. |
This would be really useful. Do you need a hand with anything @fgeller? |
+1 on this. Any updates? |
@fellyns, we should keep an eye on this one. Support for CreateTopic will be required shortly for any sort of programmatic topic creation. It's probably not a big deal yet, but could become one. |
+1 on this. It is really useful. |
Thanks for highlighting this Todd! Looking forward to this feature as it looks like we'll be needing this internally at LinkedIn soon. @fgeller If there is anything I can do to help this effort along let me know. |
This will be helpful, any update, also let me know if any help is needed? |
anyone actively working on this? |
I think it's pretty dead at this point. I'm still happy to accept a cleaned up version of this feature as described in #852 (comment) though. |
We use this change to create Kafka topics in our deployment process.