Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DATAENG-211] Topic creation fails #2

Merged
merged 3 commits into from
Feb 27, 2017
Merged

[DATAENG-211] Topic creation fails #2

merged 3 commits into from
Feb 27, 2017

Conversation

cmshetty
Copy link

Support topic creation.

  • Support nullable array in decode/encode
  • Support metadata request v1 (needed to recognize controller)
  • Send create topic request to controller

jwhitehouse-raise
jwhitehouse-raise reviewed Feb 27, 2017
View reviewed changes
broker.go Outdated
@@ -200,6 +202,7 @@ func (b *Broker) Addr() string {
}

func (b *Broker) GetMetadata(request *MetadataRequest) (*MetadataResponse, error) {
fmt.Printf("Getting metadata %v\n", *request)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove testing Printf command(s) please!

@cmshetty
Copy link
Author

Useful Links:

https://kafka.apache.org/protocol
https://cwiki.apache.org/confluence/display/KAFKA/KIP-4+-+Command+line+and+centralized+administrative+operations

@cmshetty cmshetty merged commit fc20d24 into master Feb 27, 2017
@cmshetty cmshetty deleted the chandra/fix_create_topics branch February 27, 2017 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwhitehouse-raise jwhitehouse-raise jwhitehouse-raise left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmshetty @jwhitehouse-raise