Merge upstream master changes #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mitigation for the quasi-breaking change as noted in IBM#816.
make list of brokers available through sarama.Client
Fixing two typos
Fixing link to CONTRIBUTING.MD file in README.md file
Formatting all files with gofmt -s
fix return err
Add project LICENSE
Correcting two funcs comments
Removed all else statement where if block ends with a return
AsyncClose has nothing to do with flushes at all. Close *waits* for messages to be flushed, but does not *trigger* a flush itself.
The wrapper function NewCustomHashPartitioner is a wrapper around the PartitionerConstructor, allowing for specifying the hash algorithm, which will be used.
Add functionality for custom hash partitioner.
Tweak documentation of Close/AsyncClose methods
Fix incorrect "larger than MaxRequestSize" message, closes IBM#836
Passing an already instantiated hasher is a really bad idea. Instead pass a function returning the expected interface, so the hasher is instantiated when needed, also assuring there's one hasher for each partitionDispatcher and thus avoid concurrency problems."
In Producer.Flush, if Bytes or Messages is set but Frequency is not then messages may not get flushed because Sarama will wait forever to fulfill the Byte/Message configurations.
Update dev at the same time.
Bump supported/tested go and kafka versions
Remove type hasherFunc. Adjust doc comments for the NewCustomHashPartitioner.
Fix CustomHasher
The kafka protocol for JoinGroupRequest allows you to specify priority on group protocols for seamless rollout of new protocols while a consumer group is running. The old map was not supporting that use case. Add an array field (OrderedGroupProtocols) and deprecate the map.
Permit protocol ordering in JoinGroup requests
Fix tiny typo in examples README link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.