Permit protocol ordering in JoinGroup requests #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kafka protocol for JoinGroupRequest allows you to specify priority on group protocols for seamless rollout of new protocols while a consumer group is running. The old map was not supporting that use case. Add an array field (OrderedGroupProtocols) and deprecate the map.
wvanbergen
reviewed
Mar 3, 2017
| @@ -50,7 +50,11 @@ func testVersionDecodable(t *testing.T, name string, out versionedDecoder, in [] | |||
| } | |||
|
|
|||
| func testRequest(t *testing.T, name string, rb protocolBody, expected []byte) { | |||
There was a problem hiding this comment.
I don't follow? All I did was split testRequest into the two pieces testRequestEncode and testRequestDecode; this method just calls them both.
wvanbergen
approved these changes
Mar 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kafka protocol for JoinGroupRequest allows you to specify priority
on group protocols for seamless rollout of new protocols while a
consumer group is running. The old map was not supporting that use case.
Add an array field (OrderedGroupProtocols) and deprecate the map.
Fixes #812.
@DanielMorsing @wvanbergen