Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluralizer bug #1030

Closed
ErikEJ opened this issue Feb 2, 2021 · 10 comments
Closed

Pluralizer bug #1030

ErikEJ opened this issue Feb 2, 2021 · 10 comments

Comments

@ErikEJ
Copy link

ErikEJ commented Feb 2, 2021

Bug:
Pluralize or Singularize Training
Expected: Training
Actual: training (lower case t)

See dotnet/efcore#24040

@ErikEJ
Copy link
Author

ErikEJ commented Feb 2, 2021

Looks like all 7 words here ignore casing of original word: https://github.com/Humanizr/Humanizer/blame/master/src/Humanizer/Inflections/Vocabularies.cs#L97

@GatorEcho
Copy link
Contributor

I'm new to open source but I would like to fix this.

@GatorEcho GatorEcho mentioned this issue Mar 14, 2021
11 tasks
@cgountanis
Copy link

Not fixed yet? Seems like an easy one to fix. Not sure why using extra stuff is becoming default. Remember this new EF is going to be simple and basic, otherwise people will run away. Hard enough getting new devs to use it after the old EF experience. I get the reason for plurals but does it have to be so evasive?

@ErikEJ
Copy link
Author

ErikEJ commented Apr 23, 2021

@clairernovotny Great, when is a new release planned with the fix?

@clairernovotny
Copy link
Member

clairernovotny commented Apr 23, 2021

Soon as I can narrow down the cause of the test failures here when running on .NET 5:
#1055

https://dev.azure.com/dotnet/Humanizer/_build/results?buildId=50646&view=logs&j=3dc8fd7e-4368-5a92-293e-d53cefc8c4b3&t=4cf9c106-f8f4-5b50-808b-a1dd5e6dbc8a

@ErikEJ
Copy link
Author

ErikEJ commented Apr 23, 2021

That's.... Interesting!

@ErikEJ
Copy link
Author

ErikEJ commented Apr 27, 2021

@cgountanis This fix is now included in the latest build of EF Core Power Tools

@clairernovotny
Copy link
Member

@ErikEJ make sure you're using 2.9.9 as I had to remove fil-PH by default as it was causing NuGet restore issues. #1057

@ErikEJ
Copy link
Author

ErikEJ commented Apr 27, 2021

@clairernovotny Thanks, I noticed!

@cgountanis
Copy link

Thanks Erik, looks like they fixed it at some point in the next Sprint or release as well. Not trying to ignore the power tools but I really don't want to use any third-party stuff for obvious reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants