Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent pluralization of Matrix/Vertex #1040

Closed
BrightSoul opened this issue Mar 13, 2021 · 0 comments
Closed

Inconsistent pluralization of Matrix/Vertex #1040

BrightSoul opened this issue Mar 13, 2021 · 0 comments

Comments

@BrightSoul
Copy link

BrightSoul commented Mar 13, 2021

Hello everyone, I think there's an inconsistency with pluralization and I'm asking your opinion about this.

"MatrixValue".Pluralize() returns a value of "MatricesValue". I expected it to be "MatrixValues" but... ok.
"VertexValue".Pluralize() returns a value of "VertexValues" instead, which is not consistent with the above.

So, which one of the two is correct?
I think the issue is in the regexp here

_default.AddPlural("(matr|vert|ind|d)ix|ex$", "$1ices");

Shouldn't it be...

(matr|vert|ind|d)(ix|ex)$

...or, in case you wanted a non-capturing group...

(matr|vert|ind|d)(?:ix|ex)$

That would consistently yield MatrixValues and VertexValues.
Thanks.

GatorEcho added a commit to GatorEcho/Humanizer that referenced this issue Mar 14, 2021
@GatorEcho GatorEcho mentioned this issue Mar 14, 2021
11 tasks
clairernovotny added a commit that referenced this issue Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants