-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arduino-cli 0.20.0 #89858
arduino-cli 0.20.0 #89858
Conversation
The test is failing because we removed the alpha suffix in arduino/arduino-cli#1553 |
Applying this patch should be sufficient --- <old>
+++ <new>
@@ -50,7 +50,7 @@
assert File.directory?("#{testpath}/test_sketch")
version_output = shell_output("#{bin}/arduino-cli version 2>&1")
- assert_match("arduino-cli alpha Version: #{version}", version_output)
+ assert_match("arduino-cli Version: #{version}", version_output)
assert_match("Commit:", version_output)
assert_match(/[a-f0-9]{8}/, version_output)
assert_match("Date: ", version_output) Unfortunately, I do not have push access in this PR, should I open a new one or this could be applied by one of the mantainer? Let me know 😃 |
Does it build with Go 17 now? |
That doesn't mean it doesn't work though. It just means upstream uses Go 1.16. |
Sorry @SMillerDev I misread your question, I'm trying now and yes, it does build with go 1.17.3. |
If something works with the latest version we want to have the latest version in Homebrew, consistency with upstream in dependency versions is really not a concern for us |
@SMillerDev We just finished running our tests with the binary built with go 1.17 and everything went fine, so it's ok to bump and release with go 1.17 |
--- <old>
+++ <new>
@@ -22,8 +22,8 @@
sha256 cellar: :any_skip_relocation, x86_64_linux: "9467a330e3df2f50d077c19af97e6a9cfa2e9a4546494f281c306a93450ca672"
end
- # Switch to Go 1.17 at version bump
- depends_on "[email protected]" => :build
+
+ depends_on "[email protected]" => :build
def install
ldflags = %W[ @carlocab @SMillerDev This one should do |
b8b7efa
to
68d9a1d
Compare
Co-authored-by: Carlo Cabrera <[email protected]>
68d9a1d
to
908ba6b
Compare
🤖 A scheduled task has triggered a merge. |
action-homebrew-bump-formula
Created with
brew bump-formula-pr
.