Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arduino-cli 0.20.0 #89858

Closed

Conversation

ArduinoBot
Copy link
Contributor

action-homebrew-bump-formula


Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` go Go use is a significant feature of the PR or issue labels Nov 23, 2021
@umbynos
Copy link
Contributor

umbynos commented Nov 23, 2021

The test is failing because we removed the alpha suffix in arduino/arduino-cli#1553

@umbynos
Copy link
Contributor

umbynos commented Nov 23, 2021

Applying this patch should be sufficient

--- <old>
+++ <new>
@@ -50,7 +50,7 @@
     assert File.directory?("#{testpath}/test_sketch")
 
     version_output = shell_output("#{bin}/arduino-cli version 2>&1")
-    assert_match("arduino-cli alpha Version: #{version}", version_output)
+    assert_match("arduino-cli  Version: #{version}", version_output)
     assert_match("Commit:", version_output)
     assert_match(/[a-f0-9]{8}/, version_output)
     assert_match("Date: ", version_output)

Unfortunately, I do not have push access in this PR, should I open a new one or this could be applied by one of the mantainer? Let me know 😃

@SMillerDev
Copy link
Member

Does it build with Go 17 now?

@umbynos
Copy link
Contributor

umbynos commented Nov 24, 2021

@SMillerDev
Copy link
Member

That doesn't mean it doesn't work though. It just means upstream uses Go 1.16.

@umbynos
Copy link
Contributor

umbynos commented Nov 24, 2021

Sorry @SMillerDev I misread your question, I'm trying now and yes, it does build with go 1.17.3.
We were thinking of bumping the go version we use to build upstream in the next release. In order to have consistency, would it be a problem to leave the version unchanged for this release?

@SMillerDev
Copy link
Member

If something works with the latest version we want to have the latest version in Homebrew, consistency with upstream in dependency versions is really not a concern for us

@umbynos
Copy link
Contributor

umbynos commented Nov 24, 2021

@SMillerDev We just finished running our tests with the binary built with go 1.17 and everything went fine, so it's ok to bump and release with go 1.17

@umbynos
Copy link
Contributor

umbynos commented Nov 25, 2021

--- <old>
+++ <new>
@@ -22,8 +22,8 @@
     sha256 cellar: :any_skip_relocation, x86_64_linux:   "9467a330e3df2f50d077c19af97e6a9cfa2e9a4546494f281c306a93450ca672"
   end
 
-  # Switch to Go 1.17 at version bump
-  depends_on "[email protected]" => :build
+
+  depends_on "[email protected]" => :build
 
   def install
     ldflags = %W[

@carlocab @SMillerDev This one should do

carlocab
carlocab previously approved these changes Nov 25, 2021
carlocab
carlocab previously approved these changes Nov 25, 2021
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Dec 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants