Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the alpha suffix #1553

Merged
merged 1 commit into from
Nov 19, 2021
Merged

remove the alpha suffix #1553

merged 1 commit into from
Nov 19, 2021

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Nov 18, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

generic change

  • What is the current behavior?

arduino-cli version prints an "alpha" suffix

  • What is the new behavior?

alpha is not printed anymore

yep

  • Other information:

See how to contribute

@umbynos umbynos added the topic: CLI Related to the command line interface label Nov 18, 2021
@umbynos umbynos requested a review from a team November 18, 2021 15:29
@umbynos umbynos self-assigned this Nov 18, 2021
@per1234 per1234 added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Nov 18, 2021
@umbynos umbynos force-pushed the umbynos/remove_alpha_suffix branch from 6ac61f9 to 46cd497 Compare November 19, 2021 08:36
@umbynos umbynos changed the title remove the alpha suffix and update translations remove the alpha suffix Nov 19, 2021
rsora
rsora approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@umbynos umbynos merged commit 1d24a87 into master Nov 19, 2021
@umbynos umbynos deleted the umbynos/remove_alpha_suffix branch November 19, 2021 14:00
@umbynos umbynos mentioned this pull request Nov 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsora rsora rsora approved these changes

@silvanocerza silvanocerza silvanocerza approved these changes

@cmaglie cmaglie cmaglie approved these changes

Assignees

@umbynos umbynos

Labels
topic: CLI Related to the command line interface topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@umbynos @cmaglie @silvanocerza @rsora @per1234