-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump go version to go 1.17.8 #1567
Conversation
I have run the tests locally on linux and it seems there are no regressions with go 1.17 |
Let's be cautious on this one, I would wait for other tasks to be closed, and also to dig a bit more with testing 🔎 |
BTW @silvanocerza finished running local tests on macOS and everything went smooth |
Note for future self: The homebrew version is built with go 1.17 (and not pinned) since 0.20.0 Homebrew/homebrew-core#89858 |
b1a12d4
to
99d2141
Compare
3cd3690
to
fad9881
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should also be updated to say 1.17:
- https://github.com/arduino/arduino-cli/blob/master/docs/CONTRIBUTING.md#prerequisites
- https://github.com/arduino/arduino-cli/blob/master/docs/CONTRIBUTING.md#local-development
(they were forgotten during the Go 1.14 -> 1.16 transition)
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)Update go version used
We currently use go 1.16.4
We currently use go 1.17.8
titled accordingly?
nope
See how to contribute