This repository has been archived by the owner on May 2, 2024. It is now read-only.
Update signal-beta to use .dmg instead of .zip #10272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting signing issues with the downloaded .zip As you can see [here](signalapp/Signal-Desktop#3128) it appears that others have, before, experienced issues with the .zip version. I'm not sure why there are two, but .dmg seems to not have any signing issues. Would appreciate thoughts from others as to why this issue is occurring with the .zip version. Thanks! Peter
|
Thank you @peterlewis. |
miccal
approved these changes
Jan 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting signing issues with the downloaded .zip
As you can see here it appears that others have, before, experienced issues with the .zip version.
I'm not sure why there are two, but .dmg seems to not have any signing issues. Would appreciate thoughts from others as to why this issue is occurring with the .zip version.
I'm making an assumption that the .zip version is intended for use with the internal update mechanism and, outside of this sphere, something funky occurs? This might be corroborated by this issue on their GitHub Issues.
Thanks!
Peter
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
After making all changes to a cask, verify:
brew audit --cask {{cask_file}}is error-free.brew style --fix {{cask_file}}reports no offenses.Additionally, if adding a new cask:
brew audit --new-cask {{cask_file}}worked successfully.brew install --cask {{cask_file}}worked successfully.brew uninstall --cask {{cask_file}}worked successfully.