Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds promises and subscription #36

Merged
merged 4 commits into from
Jun 25, 2021
Merged

Adds promises and subscription #36

merged 4 commits into from
Jun 25, 2021

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Jun 25, 2021

Resolves #16

@HarelM
Copy link
Collaborator Author

HarelM commented Jun 25, 2021

@RaddishIoW let me know if you want to review this.

Copy link

@RaddishIoW RaddishIoW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice work 👍🏼

@RaddishIoW RaddishIoW added this to the 1.1 milestone Jun 25, 2021
@RaddishIoW RaddishIoW added android Related to the Android platform enhancement New feature or request ios Related to the iOS platform labels Jun 25, 2021
@RaddishIoW
Copy link

Could do with updating the docs to reflect these changes before releasing 1.1, so the docs are consistent with the plugin.

@HarelM
Copy link
Collaborator Author

HarelM commented Jun 25, 2021

I'll see what I can do, great job on the docs by the way!!

@HarelM HarelM merged commit 73992d4 into develop Jun 25, 2021
@HarelM HarelM deleted the 16-promises-subscriptions branch June 25, 2021 21:42
HarelM added a commit that referenced this pull request Jun 27, 2021
* Set theme jekyll-theme-hacker

* Update Changelog

* docs: move to github pages (#35)

Fixes #32

* Update Changelog

* Adds promises and subscription (#36)

Resolves #16 

* Add promises and subscription to js interface #16 - initial commit

* #16 - fix subscriable interface

* bump version, fix docs

* fix incorrect link

* Update Changelog

* build: add workflow to automatically merge to stable on release (#42)

* Update Changelog

* GPS transactional location fetch (#38)

* [Feature] Transaction-based access to the GPS positions buffer #18 - initial commit

* [Feature] Transaction-based access to the GPS positions buffer #18 - fixes incorrect calls and missing facade and js code

* [Feature] Transaction-based access to the GPS positions buffer #18 - Fix compilation

* [Feature] Transaction-based access to the GPS positions buffer #18 - Add typesript definitions

* [Feature] Transaction-based access to the GPS positions buffer #18 - Fix iOS compilation and typo

* [Feature] Transaction-based access to the GPS positions buffer #18 - Fix iOS compilation

* [Feature] Transaction-based access to the GPS positions buffer #18 - Add missing import

* Update documentation and allow using promise.

* Update Changelog

Co-authored-by: Adam Radestock <[email protected]>
Co-authored-by: RaddishIoW <[email protected]>
Co-authored-by: HarelM <[email protected]>
HarelM added a commit that referenced this pull request Oct 1, 2021
* Set theme jekyll-theme-hacker

* Update Changelog

* docs: move to github pages (#35)

Fixes #32

* Update Changelog

* Adds promises and subscription (#36)

Resolves #16 

* Add promises and subscription to js interface #16 - initial commit

* #16 - fix subscriable interface

* bump version, fix docs

* fix incorrect link

* Update Changelog

* Support AndroidX #15 - main commit

* Bump version, update readme.

Co-authored-by: Adam Radestock <[email protected]>
Co-authored-by: RaddishIoW <[email protected]>
Co-authored-by: HarelM <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Related to the Android platform enhancement New feature or request ios Related to the iOS platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add promises and subscription to js interface
2 participants