forked from HarelM/cordova-plugin-background-geolocation
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds promises and subscription #36
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@RaddishIoW let me know if you want to review this. |
RaddishIoW
approved these changes
Jun 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Nice work 👍🏼
Could do with updating the docs to reflect these changes before releasing 1.1, so the docs are consistent with the plugin. |
I'll see what I can do, great job on the docs by the way!! |
HarelM
added a commit
that referenced
this pull request
Jun 27, 2021
* Set theme jekyll-theme-hacker * Update Changelog * docs: move to github pages (#35) Fixes #32 * Update Changelog * Adds promises and subscription (#36) Resolves #16 * Add promises and subscription to js interface #16 - initial commit * #16 - fix subscriable interface * bump version, fix docs * fix incorrect link * Update Changelog * build: add workflow to automatically merge to stable on release (#42) * Update Changelog * GPS transactional location fetch (#38) * [Feature] Transaction-based access to the GPS positions buffer #18 - initial commit * [Feature] Transaction-based access to the GPS positions buffer #18 - fixes incorrect calls and missing facade and js code * [Feature] Transaction-based access to the GPS positions buffer #18 - Fix compilation * [Feature] Transaction-based access to the GPS positions buffer #18 - Add typesript definitions * [Feature] Transaction-based access to the GPS positions buffer #18 - Fix iOS compilation and typo * [Feature] Transaction-based access to the GPS positions buffer #18 - Fix iOS compilation * [Feature] Transaction-based access to the GPS positions buffer #18 - Add missing import * Update documentation and allow using promise. * Update Changelog Co-authored-by: Adam Radestock <[email protected]> Co-authored-by: RaddishIoW <[email protected]> Co-authored-by: HarelM <[email protected]>
HarelM
added a commit
that referenced
this pull request
Oct 1, 2021
* Set theme jekyll-theme-hacker * Update Changelog * docs: move to github pages (#35) Fixes #32 * Update Changelog * Adds promises and subscription (#36) Resolves #16 * Add promises and subscription to js interface #16 - initial commit * #16 - fix subscriable interface * bump version, fix docs * fix incorrect link * Update Changelog * Support AndroidX #15 - main commit * Bump version, update readme. Co-authored-by: Adam Radestock <[email protected]> Co-authored-by: RaddishIoW <[email protected]> Co-authored-by: HarelM <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
android
Related to the Android platform
enhancement
New feature or request
ios
Related to the iOS platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16