Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add promises and subscription to js interface #16

Closed
HarelM opened this issue Apr 24, 2021 · 2 comments · Fixed by #36
Closed

Add promises and subscription to js interface #16

HarelM opened this issue Apr 24, 2021 · 2 comments · Fixed by #36
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@HarelM
Copy link
Collaborator

HarelM commented Apr 24, 2021

I'm not sure how this is done, but most of the plugins has a nice Ionic Native wrapper which helps using them and works in promises and modern stuff.
I would like this plugin to enjoy this support, I'm not familiar with the Ionic Native process in order to make this work, I guess we'll need to learn...
Adding this as a place holder for future improvements.
@RaddishIoW RaddishIoW added enhancement New feature or request help wanted Extra attention is needed labels Apr 24, 2021
@HarelM
Copy link
Collaborator Author

HarelM commented Jun 2, 2021

Posted this issue:
danielsogl/awesome-cordova-plugins#3676
And this forum discussion:
https://forum.ionicframework.com/t/background-geolocation-plugin-revival/209927
No reply yet. :-(
I'll wait for a while longer before I decide to forfeit this...

@HarelM
Copy link
Collaborator Author

HarelM commented Jun 25, 2021

Disappointing I must say... :-(
In any case, I'll use this issue to simply convert the code to use promises and subscriptions as an opt-in option.

@HarelM HarelM changed the title Add support in Ionic Native Add promises and subscription to js interface Jun 25, 2021
HarelM added a commit that referenced this issue Jun 25, 2021
@HarelM
Add promises and subscription to js interface #16 - initial commit
9baa823
HarelM added a commit that referenced this issue Jun 25, 2021
@HarelM
#16 - fix subscriable interface
4ee8e0a
@HarelM HarelM mentioned this issue Jun 25, 2021
Merged
HarelM added a commit that referenced this issue Jun 25, 2021
@HarelM
Adds promises and subscription (#36)
73992d4 
Resolves #16 

* Add promises and subscription to js interface #16 - initial commit

* #16 - fix subscriable interface

* bump version, fix docs

* fix incorrect link
HarelM added a commit that referenced this issue Jun 27, 2021
@HarelM @RaddishIoW
Version 1.1 - Merge develop into stable (#43)
188241d 
* Set theme jekyll-theme-hacker

* Update Changelog

* docs: move to github pages (#35)

Fixes #32

* Update Changelog

* Adds promises and subscription (#36)

Resolves #16 

* Add promises and subscription to js interface #16 - initial commit

* #16 - fix subscriable interface

* bump version, fix docs

* fix incorrect link

* Update Changelog

* build: add workflow to automatically merge to stable on release (#42)

* Update Changelog

* GPS transactional location fetch (#38)

* [Feature] Transaction-based access to the GPS positions buffer #18 - initial commit

* [Feature] Transaction-based access to the GPS positions buffer #18 - fixes incorrect calls and missing facade and js code

* [Feature] Transaction-based access to the GPS positions buffer #18 - Fix compilation

* [Feature] Transaction-based access to the GPS positions buffer #18 - Add typesript definitions

* [Feature] Transaction-based access to the GPS positions buffer #18 - Fix iOS compilation and typo

* [Feature] Transaction-based access to the GPS positions buffer #18 - Fix iOS compilation

* [Feature] Transaction-based access to the GPS positions buffer #18 - Add missing import

* Update documentation and allow using promise.

* Update Changelog

Co-authored-by: Adam Radestock <[email protected]>
Co-authored-by: RaddishIoW <[email protected]>
Co-authored-by: HarelM <[email protected]>
HarelM added a commit that referenced this issue Oct 1, 2021
@HarelM @RaddishIoW
Add support for AndroidX (#49)
7fd6f94 
* Set theme jekyll-theme-hacker

* Update Changelog

* docs: move to github pages (#35)

Fixes #32

* Update Changelog

* Adds promises and subscription (#36)

Resolves #16 

* Add promises and subscription to js interface #16 - initial commit

* #16 - fix subscriable interface

* bump version, fix docs

* fix incorrect link

* Update Changelog

* Support AndroidX #15 - main commit

* Bump version, update readme.

Co-authored-by: Adam Radestock <[email protected]>
Co-authored-by: RaddishIoW <[email protected]>
Co-authored-by: HarelM <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds promises and subscription HaylLtd/cordova-background-geolocation-plugin
2 participants
@HarelM @RaddishIoW