Converted the markdown generation to showdown. #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikegeyser
added
bug
…nd adding README section explaining how to generate chapters.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #219
This includes markdown rendering via showdown instead of mistune (because of the reasons mentions in this comment. Importantly, the
chapter.htmltemplate had to change to accommodate ejs, so the escaped curly braces has to be removed (which looks like a weird change). I haven't deleted the 'old' generate_chapters script, but think that it should probably also be removed.I haven't included regenerated jinja templates, so that the PR was leaner and easier to review, but I have tested it against the contents of the #215 PR. If it would help, I am happy to run it against these templates.
Please take a look, and let me know if there are any problems or suggestions?