Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up unused code and dependencies #953

Closed
tunetheweb opened this issue Jul 4, 2020 · 2 comments · Fixed by #959
Closed

Clean up unused code and dependencies #953

tunetheweb opened this issue Jul 4, 2020 · 2 comments · Fixed by #959
Labels
development Building the Almanac tech stack
Milestone
2019 Backlog

Comments

@tunetheweb
Copy link
Member

tunetheweb commented Jul 4, 2020 •
edited
Loading

I don't think we use these files (added in #114 ) any more since we changed the way we generate chapters in #222

  • generate_chapters.py
  • generate_visualisations.py
  • src/data

Also means we can get rid of the following from requirements file I think:

We may want to add some of these back in depending what we do with #896 but easy enough to re-add if we want to.

Possibly could be done at same time as #949 ?
@tunetheweb tunetheweb added the development Building the Almanac tech stack label Jul 4, 2020
@tunetheweb tunetheweb added this to the 2019 Backlog milestone Jul 4, 2020
@tunetheweb tunetheweb mentioned this issue Jul 4, 2020
Closed
@tunetheweb tunetheweb changed the title Clean up old dependencies and Clean up old dependencies Jul 4, 2020
@tunetheweb tunetheweb changed the title Clean up old dependencies Clean up unused code and dependencies Jul 4, 2020
@ibnesayeed
Copy link
Contributor

If pytest-watch is to be removed development README should be updated to exclude a relevant instruction.

@tunetheweb
Copy link
Member Author

tunetheweb commented Jul 5, 2020 •
edited
Loading

Good spot - removed that from list of suggested requirements to remove.

@tunetheweb tunetheweb mentioned this issue Jul 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
development Building the Almanac tech stack
Projects
None yet
Milestone
2019 Backlog
Development

Successfully merging a pull request may close this issue.

Clean-up old code, and update version numbers HTTPArchive/almanac.httparchive.org
2 participants
@ibnesayeed @tunetheweb