-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance chapter #215
Performance chapter #215
Conversation
Reading through and adding comments to the google doc right now 👍 |
Thanks @OBTo! To keep everything in one place, going forward could you add your comments as a review on this PR? |
@rviscomi Do you want me to add the comments I had already placed in the google doc, in here as well? |
Yes please :) |
@rviscomi Can you re-enable comments on the doc for a few minutes so I can copy+paste what I wrote? |
@OBTo @sergeychernyshev @zeman any other feedback/comments? |
Hope to give it another look today. |
Thanks @OBTo and @JMPerez for signing off! @sergeychernyshev I'll wait for your feedback before merging. @zeman LMK if you have any other feedback. Post-merge is ok too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments. Overall looks good.
Thanks everyone! |
* generate chapters * chapter styles/viz (first steps) * fix outline * Performance chapter (#215) * performance chapter markup * wpo stats link * rephrase conclusion * feedback
Closes #171
Converted from https://docs.google.com/document/d/1S0De_lBFCuqLWa2ZlB31SKQZE_zkboweeAUWLrcDuLw/edit?usp=sharing
Looks like the md tables aren't rendering to html correctly, I'll look into that separately (cc @mikegeyser). Ignore that for now.
Looking to get a final LGTM from the reviewers.