Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance chapter #215

Merged
merged 5 commits into from
Oct 23, 2019
Merged

Performance chapter #215

merged 5 commits into from
Oct 23, 2019

Conversation

rviscomi
Copy link
Member

@rviscomi rviscomi commented Oct 21, 2019

Closes #171

Converted from https://docs.google.com/document/d/1S0De_lBFCuqLWa2ZlB31SKQZE_zkboweeAUWLrcDuLw/edit?usp=sharing

Looks like the md tables aren't rendering to html correctly, I'll look into that separately (cc @mikegeyser). Ignore that for now.

Looking to get a final LGTM from the reviewers.

@rviscomi rviscomi added the writing Related to wording and content label Oct 21, 2019
@rviscomi rviscomi added this to the Content written milestone Oct 21, 2019
@foxdavidj
Copy link
Contributor

Reading through and adding comments to the google doc right now 👍

@rviscomi
Copy link
Member Author

Thanks @OBTo! To keep everything in one place, going forward could you add your comments as a review on this PR?

@foxdavidj
Copy link
Contributor

@rviscomi Do you want me to add the comments I had already placed in the google doc, in here as well?

@rviscomi
Copy link
Member Author

Yes please :)

@foxdavidj
Copy link
Contributor

@rviscomi Can you re-enable comments on the doc for a few minutes so I can copy+paste what I wrote?

src/content/en/2019/performance.md Outdated Show resolved Hide resolved
src/content/en/2019/performance.md Show resolved Hide resolved
src/content/en/2019/performance.md Outdated Show resolved Hide resolved
@rviscomi rviscomi changed the base branch from chapters to master October 22, 2019 01:21
@rviscomi rviscomi changed the base branch from master to chapters October 22, 2019 01:21
src/content/en/2019/performance.md Outdated Show resolved Hide resolved
@rviscomi
Copy link
Member Author

@OBTo @sergeychernyshev @zeman any other feedback/comments?

@sergeychernyshev
Copy link

Hope to give it another look today.

@rviscomi
Copy link
Member Author

Thanks @OBTo and @JMPerez for signing off!

@sergeychernyshev I'll wait for your feedback before merging.

@zeman LMK if you have any other feedback. Post-merge is ok too.

Copy link

@sergeychernyshev sergeychernyshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Overall looks good.

src/content/en/2019/performance.md Outdated Show resolved Hide resolved
src/content/en/2019/performance.md Outdated Show resolved Hide resolved
src/content/en/2019/performance.md Show resolved Hide resolved
@rviscomi
Copy link
Member Author

Thanks everyone!

@rviscomi rviscomi merged commit b3564d1 into chapters Oct 23, 2019
@rviscomi rviscomi deleted the performance branch October 23, 2019 21:30
rviscomi added a commit that referenced this pull request Oct 23, 2019
* generate chapters

* chapter styles/viz (first steps)

* fix outline

* Performance chapter (#215)

* performance chapter markup

* wpo stats link

* rephrase conclusion

* feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
writing Related to wording and content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants