New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Funnel -> subsystems-dev #7

Merged

drorta merged 32 commits into subsystems-dev from funnel-withswerve

Oct 4, 2024

drorta commented Oct 1, 2024

No description provided.

drorta added 2 commits

October 1, 2024 23:44


          come on

1ac1982


          sort stuff'

ac63b9a

drorta self-assigned this

github-actions bot added needs-robot-testing labels


          spotless

1e1535a

YHerm reviewed

View reviewed changes

src/main/java/frc/robot/subsystems/funnel/FunnelCommandsBuilder.java Outdated Show resolved Hide resolved

YHerm reviewed

View reviewed changes

src/main/java/frc/robot/subsystems/funnel/FunnelStuff.java Outdated Show resolved Hide resolved

YHerm reviewed

View reviewed changes

src/main/java/frc/robot/subsystems/funnel/factory/RealFunnelConstants.java Outdated Show resolved Hide resolved

YHerm reviewed

View reviewed changes

src/main/java/frc/robot/subsystems/funnel/factory/RealFunnelConstants.java Outdated Show resolved Hide resolved

YHerm reviewed

View reviewed changes

src/main/java/frc/robot/subsystems/funnel/FunnelCommandsBuilder.java Outdated Show resolved Hide resolved

YHerm reviewed

View reviewed changes

src/main/java/frc/robot/subsystems/funnel/FunnelCommandsBuilder.java Outdated Show resolved Hide resolved

YHerm reviewed

View reviewed changes

src/main/java/frc/robot/subsystems/funnel/FunnelCommandsBuilder.java Outdated Show resolved Hide resolved

YHerm previously approved these changes

View reviewed changes

cr

d09a151

drorta dismissed YHerm’s stale review via

d09a151

October 1, 2024 21:42

YHerm reviewed

View reviewed changes

src/main/java/frc/robot/subsystems/funnel/factory/RealFunnelConstants.java Outdated Show resolved Hide resolved


          getvoltage

f3ff9a4

YHerm changed the base branch from core to subsystems-dev

October 1, 2024 21:47

YHerm changed the title ~~Funnel -> core~~ Funnel -> subsystems-dev


          onelione

49a3596

YHerm reviewed

View reviewed changes

src/main/java/frc/robot/subsystems/funnel/Funnel.java Outdated Show resolved Hide resolved

YHerm reviewed

View reviewed changes

src/main/java/frc/robot/subsystems/funnel/Funnel.java Show resolved Hide resolved

YHerm reviewed

View reviewed changes

src/main/java/frc/robot/subsystems/funnel/Funnel.java Outdated Show resolved Hide resolved

YHerm reviewed

View reviewed changes

src/main/java/frc/robot/subsystems/funnel/Funnel.java Outdated Show resolved Hide resolved

YHerm reviewed

View reviewed changes

src/main/java/frc/robot/subsystems/funnel/Funnel.java Outdated Show resolved Hide resolved

YHerm reviewed

View reviewed changes

src/main/java/frc/robot/subsystems/funnel/factory/RealFunnelConstants.java Outdated Show resolved Hide resolved

cr

ab27594

YHerm reviewed

View reviewed changes

src/main/java/frc/robot/subsystems/funnel/factory/RealFunnelConstants.java Outdated Show resolved Hide resolved

greenblitz4590 dismissed stale reviews from bossyshrimp68, Yotam7, and YHerm via

ef73d2b

October 4, 2024 14:42

github-actions bot added needs-robot-testing needs-simulation-testing labels

greenblitz4590 removed needs-robot-testing needs-simulation-testing labels

bossyshrimp68 previously approved these changes

View reviewed changes

greenblitz4590 added the PASSED ALL TESTS label


          spotless

39861db

greenblitz4590 dismissed bossyshrimp68’s stale review via

39861db

October 4, 2024 14:46

github-actions bot added needs-robot-testing needs-simulation-testing labels

greenblitz4590 removed needs-robot-testing needs-simulation-testing labels

bossyshrimp68 previously approved these changes

View reviewed changes


          fuckkkk

3c5cf04

greenblitz4590 dismissed bossyshrimp68’s stale review via

3c5cf04

October 4, 2024 14:50

github-actions bot added needs-robot-testing needs-simulation-testing labels

YHerm approved these changes

View reviewed changes

bossyshrimp68 approved these changes

View reviewed changes

drorta removed needs-robot-testing needs-simulation-testing labels

hillelv approved these changes

View reviewed changes

Yotam7 approved these changes

View reviewed changes

Nitay4 reviewed

View reviewed changes

src/main/java/frc/robot/constants/IDs.java Show resolved Hide resolved

src/main/java/frc/robot/subsystems/funnel/FunnelConstants.java Show resolved Hide resolved

src/main/java/frc/robot/subsystems/funnel/factory/RealFunnelConstants.java Show resolved Hide resolved

Nitay4 approved these changes

View reviewed changes

drorta merged commit 2f5902e into subsystems-dev

4 of 7 checks passed

YHerm deleted the funnel-withswerve branch

October 8, 2024 10:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Yotam7 Yotam7 approved these changes

bossyshrimp68 bossyshrimp68 approved these changes

YHerm YHerm approved these changes

hillelv hillelv approved these changes

Nitay4 Nitay4 approved these changes

YoniKiriaty YoniKiriaty left review comments

GilStein1 GilStein1 left review comments

maya1414 maya1414 left review comments

Labels

A-SMALL-PR PASSED ALL TESTS SUBSYSTEM