Migrate mock-observations to builtins
#710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcook1186
changed the title
mock-observations to builtins
jmcook1186
commented
May 20, 2024
Signed-off-by: Joseph Cook <[email protected]>
manushak
reviewed
May 21, 2024
manushak
reviewed
May 21, 2024
jmcook1186
commented
May 21, 2024
Signed-off-by: Joseph Cook <[email protected]>
6 tasks
Signed-off-by: Joseph Cook <[email protected]>
manushak
approved these changes
May 21, 2024
Signed-off-by: Joseph Cook <[email protected]>
| /** | ||
| * Generates next value by copying the validated config. | ||
| */ | ||
| const next = (_historical: Object[] | undefined): Object => |
There was a problem hiding this comment.
please fix this warnings
Signed-off-by: Joseph Cook <[email protected]>
…en-Software-Foundation/ief into migrate-mock-obs-to-builtins
|
warnings seems still there |
|
one warning is still there, but I'm not sure that the parameter can really be removed - can you take a look? |
Signed-off-by: Joseph Cook <[email protected]>
narekhovhannisyan
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
A description of the changes proposed in the Pull Request
Migrates
mock-observationsfrom plugins to builtins.Dev review - @narekhovhannisyan please check that changes in the plugin source code are benign (specifially making execute synchronous).
Addresses #678