Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mock-observations to if/builtins #678

Closed
6 tasks
Tracked by #656
zanete opened this issue Apr 29, 2024 · 2 comments · Fixed by #710
Closed
6 tasks
Tracked by #656

Move mock-observations to if/builtins #678

zanete opened this issue Apr 29, 2024 · 2 comments · Fixed by #710
Assignees
Milestone

Comments

@zanete
Copy link

zanete commented Apr 29, 2024

Sub of: #656

What
Move the MockObservations plugin from if-plugins to if/builtins

Why
This is part of our migration of our core plugins into a standard library in if/builtins.

Context
This is a core feature we want to support, so it is migrating into if.

Prerequisites/resources
no

SoW (scope of work)

  • move plugin code into builtins/mock-observations
  • fix any integration issues caused by the migration
  • migrate and fix unit tests
  • update README documentation updated

Acceptance criteria

  • plugin code is migrated to if-builtins
    Given (Setup): The migration has been completed.
    When (Action): A user or developer navigates to if
    Then (Assertion): they will find a folder if/builtins/mock-observations containing the plugin source code and a README.

  • plugin code and unit tests pass and maintain 100% coverage
    Given (Setup): The migration has been completed and a user has downloaded if.
    When (Action): they run npx jest --coverage
    Then (Assertion): they will receive a report showing 100% coverage and 100% passing

@zanete zanete moved this to Backlog in IF Apr 29, 2024
@zanete zanete added this to the Plugin Registry milestone Apr 29, 2024
@zanete zanete mentioned this issue Apr 29, 2024
28 tasks
@zanete zanete moved this from Backlog to In Design in IF May 7, 2024
@jmcook1186 jmcook1186 moved this from In Design to In Refinement in IF May 10, 2024
@jmcook1186 jmcook1186 moved this from In Refinement to Ready in IF May 10, 2024
@jmcook1186 jmcook1186 moved this from Ready to Pending Review in IF May 10, 2024
@zanete
Copy link
Author

zanete commented May 20, 2024

@manushak please review the PR

@manushak
Copy link
Contributor

@manushak please review the PR

done

@jmcook1186 jmcook1186 linked a pull request May 21, 2024 that will close this issue
9 tasks
@manushak manushak removed their assignment May 21, 2024
@zanete zanete moved this from Pending Review to In Progress in IF May 23, 2024
@zanete zanete moved this from In Progress to Testing in IF May 24, 2024
@github-project-automation github-project-automation bot moved this from Testing to Done in IF May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants