-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added JsonForecast datasource #312
Added JsonForecast datasource #312
Conversation
Signed-off-by: Margaret <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev #312 +/- ##
==========================================
+ Coverage 81.73% 81.86% +0.13%
==========================================
Files 69 69
Lines 2392 2459 +67
Branches 244 252 +8
==========================================
+ Hits 1955 2013 +58
- Misses 355 360 +5
- Partials 82 86 +4
|
Signed-off-by: Margaret <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving from Newtonsoft to System.Text.Json was a good catch! I just added few comments.
...onAware.DataSources/CarbonAware.DataSources.ElectricityMaps/src/ElectricityMapsDataSource.cs
Show resolved
Hide resolved
src/CarbonAware.WebApi/test/integrationTests/IntegrationTestingBase.cs
Outdated
Show resolved
Hide resolved
I, Margaret <[email protected]>, hereby add my Signed-off-by to this commit: 37803b6 Signed-off-by: Margaret <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look great. Awesome gap to fill to so thank you. Very much appreciated.
Signed-off-by: Vaughan Knight <[email protected]>
From the errors it looks like the test data json file might have issues, I need to look into it. I don't think it's a code issue at this time, but likely a test data file issue. |
@vaughanknight could you confirm whether we are holding off with merging this until after the release? |
bringing this back up, to confirm whether fixing this is being held off until post v1.1 @vaughanknight |
From #405 : currently available to pick up for review |
#417 To decide whether to close this off on next meeting - has been broken for a while and no one volunteered to fix/pick this up. |
This has been breaking for too long and is not a critical feature. It was a great contribution we will revisit using the latest code. |
Pull Request
Issue Number: (Link to Github Issue or Azure Dev Ops Task/Story)
Summary
Added JsonForecast datasource
Changes
Checklist
Are there API Changes?
If yes, what are the expected API Changes? Please link to an API-Comparison
workflow with the API Diff.
Is this a breaking change?
If yes, what workflow does this break?
Anything else?
Other comments, collaborators, etc.
This PR Closes #<issue_number>