Add timeout for validation command #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernd
requested changes
Jul 5, 2018
There was a problem hiding this comment.
The windows build fails on Jenkins:
# github.com/Graylog2/collector-sidecar/daemon
daemon/svc_runner_windows.go:67:2: cannot use r (type *SvcRunner) as type Runner in return argument:
*SvcRunner does not implement Runner (wrong type for GetBackend method)
have GetBackend() backends.Backend
want GetBackend() *backends.Backend
daemon/svc_runner_windows.go:77:3: undefined: backends.SetStatusLogErrorf
daemon/svc_runner_windows.go:85:3: undefined: backends.SetStatusLogErrorf
daemon/svc_runner_windows.go:92:3: undefined: backends.SetStatusLogErrorf
daemon/svc_runner_windows.go:123:10: undefined: backends.SetStatusLogErrorf
daemon/svc_runner_windows.go:128:10: undefined: backends.SetStatusLogErrorf
daemon/svc_runner_windows.go:150:4: undefined: backends.SetStatusLogErrorf
daemon/svc_runner_windows.go:158:4: undefined: backends.SetStatusLogErrorf
daemon/svc_runner_windows.go:164:4: undefined: backends.SetStatusLogErrorf
daemon/svc_runner_windows.go:187:4: undefined: backends.SetStatusLogErrorf
daemon/svc_runner_windows.go:187:4: too many errors
github.com/Graylog2/collector-sidecar/api/rest
make: *** [build-windows] Error 2
bernd
approved these changes
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #239
Should the value for the timeout be configurable, it's set to 30s currently.