Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup backend access #244

Merged
merged 1 commit into from
Jul 3, 2018
Merged

Cleanup backend access #244

merged 1 commit into from
Jul 3, 2018

Conversation

mariussturm
Copy link
Contributor

Fixes #238

##Explanation
We store a 1:1 copy of the available collectors of the Graylog server in the structure called backends.Store. When a configuration is assigned to a Sidecar a new Runner instance is created with a copy of the responding Backend. Now we have to make sure that status changes (as well as configuration changes/compares) are made to that copied Backend and not to the original list of backends. We need that copy to allow multiple instances of the same collector type.

@mariussturm mariussturm added this to the 3.0.0 milestone Jul 2, 2018
@mariussturm mariussturm requested a review from bernd July 2, 2018 15:03
@bernd bernd self-assigned this Jul 3, 2018
Copy link
Member

@bernd bernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue I was seeing. LGTM 👍

@bernd bernd merged commit fdd6f0f into master Jul 3, 2018
@bernd bernd deleted the issue-238 branch July 3, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants