Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement timeout for collector config test #239

Closed
bernd opened this issue Jun 27, 2018 · 0 comments
Closed

Implement timeout for collector config test #239

bernd opened this issue Jun 27, 2018 · 0 comments
Labels
Milestone

Comments

@bernd
Copy link
Member

bernd commented Jun 27, 2018

Problem description

The collector config test command ("Parameters for Configuration Validation") needs to be executed with a timeout so it cannot block forever.

I ran into this when testing the new disk spool (beta) feature of the newer filebeat versions. Testing the filebeat configuration with a configured disk spool seems to be locking the disk spool directory/file. This is a problem when there is an existing filebeat instance running that is using the same disk spool config. The test command blocked indefinitely.

I consider this a bug in the filebeat implementation but the sidecar needs a timeout for the test command to avoid blocking the collector test. Something like this can happen with other collector backends as well.

Steps to reproduce the problem

  1. Configure a filebeat backend with a disk spool
  2. Let the sidecar start the filebeat backend
  3. Edit and save the filebeat configuration in graylog
  4. Watch the sidecar executing the test command for the filebeat ➡️ it never finishes

Environment

  • Sidecar Version: 1.0.0-alpha.1 (rev d92f8e5)
  • Graylog Version: 3.0.0-alpha.2-SNAPSHOT (rev 20ab7325e)
@bernd bernd added the bug label Jun 27, 2018
@bernd bernd added this to the 3.0.0 milestone Jun 27, 2018
@bernd bernd closed this as completed in #245 Jul 5, 2018
bernd pushed a commit that referenced this issue Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant