Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Gradle 8.9 & Java 21 #876

Merged
merged 86 commits into from
Aug 1, 2024
Merged

Support Gradle 8.9 & Java 21 #876

merged 86 commits into from
Aug 1, 2024

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Jul 20, 2023

renovate bot and others added 10 commits July 20, 2023 12:14
* chore(deps): update dependency gradle to v8.2.1

* Use org.gradle.configuration-cache flag

* Update shadow-version.txt

* Migrate deprecated ApplicationPluginConvention usages
https://docs.gradle.org/8.2.1/javadoc/org/gradle/api/plugins/ApplicationPluginConvention.html

* Fix test framework deprecation warning
https://docs.gradle.org/8.2.1/userguide/upgrading_version_8.html#test_framework_implementation_dependencies

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Goooler <[email protected]>
@Goooler Goooler changed the title Minor updates Support Gradle 8.3 Aug 17, 2023
renovate bot and others added 2 commits August 17, 2023 22:18
* chore(deps): update dependency gradle to v8.3

* Impl getPermissions
https://docs.gradle.org/8.3/javadoc/org/gradle/api/file/FileTreeElement.html#getPermissions--

* Min Gradle 8.3

* Bump org.gradle.toolchains.foojay-resolver-convention

* Migrate deprecated buildDir
https://docs.gradle.org/8.3/javadoc/org/gradle/api/Project.html#getBuildDir--

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Goooler <[email protected]>
Copy link
Contributor

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me though more Java versions could be tested on CI

@reneleonhardt
Copy link

GitHub doesn't allow me to reply to ShadowBasePlugin.groovy 🤷
README should be updated when Gradle 8.3+ is required now.

@Goooler
Copy link
Member Author

Goooler commented Aug 1, 2024

You mean

| 8.x | 8.0.0+ |

?

It also includes 8.0 ~ 8.1, it might be ambiguous.

@reneleonhardt
Copy link

You mean

| 8.x | 8.0.0+ |

?

It also includes 8.0 ~ 8.1, it might be ambiguous.

Yes, if the next release isn't compatible with Gradle 8.0 anymore, this line should be changed to something like this

shadow gradle
8.0+, 8.1+ 8.0.0+
8.2+ 8.3.0+

@Goooler
Copy link
Member Author

Goooler commented Aug 5, 2024

Noted it in #930.

@Goooler Goooler mentioned this pull request Aug 5, 2024
TAKETODAY added a commit to TAKETODAY/today-infrastructure that referenced this pull request Aug 11, 2024
This commit fixes to a fork of the shadow plugin that fixes support
with recent Gradle releases.

See GradleUp/shadow#876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment