-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Gradle 8.9 & Java 21 #876
Conversation
https://github.com/codehaus-plexus/plexus-utils#plexus-utils https://github.com/codehaus-plexus/plexus-xml/releases/tag/plexus-xml-4.0.2 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Goooler <[email protected]>
* chore(deps): update dependency gradle to v8.2.1 * Use org.gradle.configuration-cache flag * Update shadow-version.txt * Migrate deprecated ApplicationPluginConvention usages https://docs.gradle.org/8.2.1/javadoc/org/gradle/api/plugins/ApplicationPluginConvention.html * Fix test framework deprecation warning https://docs.gradle.org/8.2.1/userguide/upgrading_version_8.html#test_framework_implementation_dependencies --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Goooler <[email protected]>
src/main/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowBasePlugin.groovy
Show resolved
Hide resolved
* chore(deps): update dependency gradle to v8.3 * Impl getPermissions https://docs.gradle.org/8.3/javadoc/org/gradle/api/file/FileTreeElement.html#getPermissions-- * Min Gradle 8.3 * Bump org.gradle.toolchains.foojay-resolver-convention * Migrate deprecated buildDir https://docs.gradle.org/8.3/javadoc/org/gradle/api/Project.html#getBuildDir-- --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Goooler <[email protected]>
* chore(deps): update actions/checkout digest to 8ade135 * Update gradle-wrapper-validation.yml --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Goooler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me though more Java versions could be tested on CI
src/main/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowBasePlugin.groovy
Show resolved
Hide resolved
...y/com/github/jengelman/gradle/plugins/shadow/transformers/ManifestAppenderTransformer.groovy
Show resolved
Hide resolved
GitHub doesn't allow me to reply to ShadowBasePlugin.groovy 🤷 |
You mean Line 21 in 065f6ba
? It also includes 8.0 ~ 8.1, it might be ambiguous. |
Yes, if the next release isn't compatible with Gradle 8.0 anymore, this line should be changed to something like this
|
Noted it in #930. |
This commit fixes to a fork of the shadow plugin that fixes support with recent Gradle releases. See GradleUp/shadow#876
destinationDir
which has been changed fordestinationDirectory
#925.As a workaround, you can try out my fork, see https://plugins.gradle.org/plugin/io.github.goooler.shadow.Changes have been released, see https://github.com/GradleUp/shadow/releases/tag/8.3.0.