Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix java 20 support #879

Closed
wants to merge 1 commit into from
Closed

Fix java 20 support #879

wants to merge 1 commit into from

Conversation

rafi67000
Copy link

bump jdependency version to 2.9.0 (ASM related)

Copy link

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's much needed for Java 20 support.

Could we get a release including this change please, @johnrengelman ?

Copy link

@rfresh2 rfresh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested and fixes minimize task on JDK21

@Goooler Goooler mentioned this pull request Oct 28, 2023
@Goooler
Copy link
Member

Goooler commented Oct 31, 2023

Ones who need this can try my fork, see #876 (comment).

@Nek-12
Copy link

Nek-12 commented Feb 4, 2024

When will this be merged? It's been half a year for 1 line of changes.

@rafi67000
Copy link
Author

it's been a year since last commit so shadow is dead.

@Goooler
Copy link
Member

Goooler commented Jul 28, 2024

Closing due to #876.

@Goooler Goooler closed this Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants