Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation when running on Gradle 8.8 #919

Closed
wants to merge 3 commits into from

Conversation

britter
Copy link

@britter britter commented Apr 30, 2024

CopyProcessingSpec.fileMode was recently deprecated. It is replaced by
the filePermissions method, that was introduced in 8.3.
For that reason this change updates the build to 8.3 to be able to call
filePermissions. The code then uses that method if running on 8.3 or
higher. If not, it falls back to calling fileMode.

`CopyProcessingSpec.fileMode` was recently deprecated. It is replaced by
the `filePermissions` method, that was introduced in 8.3.
For that reason this change updates the build to 8.3 to be able to call
`filePermissions`. The code then uses that method if running on 8.3 or
higher. If not, it falls back to calling `fileMode`.
@britter
Copy link
Author

britter commented May 1, 2024

@johnrengelman I can fix the failing tests that complain about deprecations by replacing usages of ApplicationConventions. I don't see a way to make the plugin work on Gradle 8.0 (Build Scan). This is because the API surface of the FileTreeElement has changed, and the code in this plugin implements that. I don't see a way to conditionally implement this. So my proposal is to bump the min Gradle requirement to Gradle 8.3 instead.

Goooler
Goooler previously approved these changes May 3, 2024
@Goooler
Copy link
Member

Goooler commented May 3, 2024

Duplicate of #876

@Goooler
Copy link
Member

Goooler commented Jul 28, 2024

Closing due to #876.

@Goooler Goooler closed this Jul 28, 2024
@britter britter deleted the britter/fix-gradle-deprecation branch August 1, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants