Add support for urls in deploy.kubectl.manifests

[r2d4]

apiVersion: skaffold/v1alpha5
kind: Config
build:
  artifacts:
  - image: gcr.io/k8s-skaffold/skaffold-example
deploy:
  kubectl:
    manifests:
      - https://raw.githubusercontent.com/GoogleContainerTools/skaffold/master/examples/getting-started/k8s-pod.yaml

[r2d4]

fixes #1408

[codecov-io]

Codecov Report

Merging #1408 into master will decrease coverage by 0.03%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##           master    #1408      +/-   ##
==========================================
- Coverage   44.65%   44.61%   -0.04%     
==========================================
  Files         111      111              
  Lines        4546     4552       +6     
==========================================
+ Hits         2030     2031       +1     
- Misses       2311     2315       +4     
- Partials      205      206       +1

Impacted Files	Coverage Δ
pkg/skaffold/deploy/kubectl.go	50.54% <16.66%> (-2.4%)	⬇️
pkg/skaffold/util/util.go	52.13% <40%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4da3012...37a9e5a. Read the comment docs.

[codecov-io]

Codecov Report

Merging #1408 into master will decrease coverage by 0.03%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##           master    #1408      +/-   ##
==========================================
- Coverage   44.65%   44.61%   -0.04%     
==========================================
  Files         111      111              
  Lines        4546     4552       +6     
==========================================
+ Hits         2030     2031       +1     
- Misses       2311     2315       +4     
- Partials      205      206       +1

Impacted Files	Coverage Δ
pkg/skaffold/deploy/kubectl.go	50.54% <16.66%> (-2.4%)	⬇️
pkg/skaffold/util/util.go	52.13% <40%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4da3012...37a9e5a. Read the comment docs.

[r2d4]

--- FAIL: TestRun/bazel_example (5.85s)
    	run_test.go:183: skaffold: Starting build...
    		Building [gcr.io/k8s-skaffold/skaffold-bazel]...
    		Extracting Bazel installation...
    		Starting local Bazel server and connecting to it...
    		INFO: Invocation ID: 34c478e4-4ab3-444d-8651-f0d140f2f027
    		Loading:
    		Loading: 0 packages loaded
    		ERROR: error loading package '': Encountered error while reading extension file 'go/def.bzl': no such package '@io_bazel_rules_go//go': The native http_archive rule is deprecated. load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") for a drop-in replacement.
    		Use --incompatible_remove_native_http_archive=false to temporarily continue using the native rule.
    		ERROR: error loading package '': Encountered error while reading extension file 'go/def.bzl': no such package '@io_bazel_rules_go//go': The native http_archive rule is deprecated. load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") for a drop-in replacement.
    		Use --incompatible_remove_native_http_archive=false to temporarily continue using the native rule.
    		INFO: Elapsed time: 5.746s
    		INFO: 0 processes.
    		FAILED: Build did NOT complete successfully (0 packages loaded)
    		FAILED: Build did NOT complete successfully (0 packages loaded)
    		 Running [skaffold run --namespace skaffoldcntht]: stdout Starting build...
    		Building [gcr.io/k8s-skaffold/skaffold-bazel]...
    		Extracting Bazel installation...
    		Starting local Bazel server and connecting to it...
    		INFO: Invocation ID: 34c478e4-4ab3-444d-8651-f0d140f2f027
    		Loading:
    		Loading: 0 packages loaded
    		ERROR: error loading package '': Encountered error while reading extension file 'go/def.bzl': no such package '@io_bazel_rules_go//go': The native http_archive rule is deprecated. load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") for a drop-in replacement.
    		Use --incompatible_remove_native_http_archive=false to temporarily continue using the native rule.
    		ERROR: error loading package '': Encountered error while reading extension file 'go/def.bzl': no such package '@io_bazel_rules_go//go': The native http_archive rule is deprecated. load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") for a drop-in replacement.
    		Use --incompatible_remove_native_http_archive=false to temporarily continue using the native rule.
    		INFO: Elapsed time: 5.746s
    		INFO: 0 processes.
    		FAILED: Build did NOT complete successfully (0 packages loaded)
    		FAILED: Build did NOT complete successfully (0 packages loaded)
    		, stderr: time="2018-12-20T19:37:37Z" level=fatal msg="build step: building [gcr.io/k8s-skaffold/skaffold-bazel]: build artifact: running command: exit status 1"
    		, err: exit status 1: exit status 1

[balopat]

fixes #1408

fixes #1353

[balopat]

Thank you for this @r2d4 :)

@ahmadnurus this overlaps with your implementation - but one thing I prefer about this approach is
that it keeps the config change minimal. Do you mind closing #1354?

[balopat]

I'm not sure I understand why the bazel example fails in kokoro only on this PR, but I'm looking.

[ghost]

@balopat I don't know if you prefer with mininal config change. I can change my PR if you review my PR earlier. but it's ok to close my PR for this.

[balopat]

Thanks @ahmadnurus, sorry for the inconvenience!

[balopat]

It's super odd but I cannot reproduce this bazel failure on any other PRs - including a complete clone of this PR, locally on docker (cleaned from bazel cache, docker images, etc.). It must be a peculiar kokoro thing.

[balopat]

Ignoring the bazel error as it seems to be a kokoro related flake.

[ghost]

np @balopat , tell me if any issue that i can take!