Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support kubectl deploy using manifest from url #1353

Closed
ghost opened this issue Dec 2, 2018 · 2 comments
Closed

Support kubectl deploy using manifest from url #1353

ghost opened this issue Dec 2, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented Dec 2, 2018

Expected behavior

Sometimes we need to deploy using manifests that doesn't exist in the local machine. like someone only provides the manifest in remote repository, snippet or gists. it would be better if skaffold support deploying using manifest from url.

This might look the following:

apiVersion: skaffold/v1beta1
kind: Config
build:
...
deploy:
  kubectl:
  # ------------- from file ------------- #
    manifests:
    - mylocal/manifest/*.yml
  # ------------- from url -------------- #
    urlManifests:
    - https://gist.githubusercontent.com/someone/somesnippet/raw
    - https://raw.githubusercontent.com/GoogleContainerTools/skaffold/master/examples/getting-started/k8s-pod.yaml

and we don't need to execute kubectl apply -f https://gist.githubusercontent.com/someone/somesnippet/raw for manifests that doesn't exist in the local machine.

Actual behavior

Not supported yet

Steps to reproduce the behavior

  1. Add URLManifests in KubectlDeploy struct schema
  2. Create some function to read manifest from url eg: using http.NewRequest and append it to kubectl.ManifestList
@dgageot dgageot changed the title Feature request: Support kubectl deploy using manifest from url Support kubectl deploy using manifest from url Dec 3, 2018
@ghost
Copy link
Author

ghost commented Dec 22, 2018

/close fixed #1408

@ghost ghost closed this as completed Dec 22, 2018
@williamlord
Copy link

I think this has regressed after v0.21.0.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants