Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove #2322

Closed
ghost opened this issue Jun 23, 2019 · 6 comments · Fixed by #2348
Closed

remove #2322

ghost opened this issue Jun 23, 2019 · 6 comments · Fixed by #2348
Assignees
Labels
deploy/kubectl kind/bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jun 23, 2019

Democracy is good.  I say this because other systems are worse.
		-- Jawaharlal Nehru
@dgageot
Copy link
Contributor

dgageot commented Jun 23, 2019

Hi @braderhart, you should use this config:

apiVersion: skaffold/v1beta11
kind: Config

deploy:
  kubectl:
    remoteManifests:
    - https://raw.githubusercontent.com/aws/amazon-vpc-cni-k8s/master/config/v1.5/aws-k8s-cni.yaml

@seblegall
Copy link
Contributor

@dgageot it seems the RemoteManifests field is never used except in the configuration declaration.

$ grep -nr RemoteManifests ./

.//pkg/skaffold/schema/v1beta4/config.go:166:	RemoteManifests []string     `yaml:"remoteManifests,omitempty"`
.//pkg/skaffold/schema/v1beta10/config.go:316:	// RemoteManifests lists Kubernetes manifests in remote clusters.
.//pkg/skaffold/schema/v1beta10/config.go:317:	RemoteManifests []string `yaml:"remoteManifests,omitempty"`
.//pkg/skaffold/schema/v1beta3/config.go:165:	RemoteManifests []string     `yaml:"remoteManifests,omitempty"`
.//pkg/skaffold/schema/v1beta2/config.go:156:	RemoteManifests []string     `yaml:"remoteManifests,omitempty"`
.//pkg/skaffold/schema/v1beta5/config.go:319:	// RemoteManifests lists Kubernetes manifests in remote clusters.
.//pkg/skaffold/schema/v1beta5/config.go:320:	RemoteManifests []string `yaml:"remoteManifests,omitempty"`
.//pkg/skaffold/schema/v1alpha2/config.go:127:	RemoteManifests []string     `yaml:"remoteManifests,omitempty"`
.//pkg/skaffold/schema/v1alpha5/config.go:159:	RemoteManifests []string     `yaml:"remoteManifests,omitempty"`
.//pkg/skaffold/schema/v1alpha4/config.go:149:	RemoteManifests []string     `yaml:"remoteManifests,omitempty"`
.//pkg/skaffold/schema/v1alpha3/config.go:133:	RemoteManifests []string     `yaml:"remoteManifests,omitempty"`
.//pkg/skaffold/schema/latest/config.go:323:	// RemoteManifests lists Kubernetes manifests in remote clusters.
.//pkg/skaffold/schema/latest/config.go:324:	RemoteManifests []string `yaml:"remoteManifests,omitempty"`
.//pkg/skaffold/schema/v1beta7/config.go:305:	// RemoteManifests lists Kubernetes manifests in remote clusters.
.//pkg/skaffold/schema/v1beta7/config.go:306:	RemoteManifests []string `yaml:"remoteManifests,omitempty"`
.//pkg/skaffold/schema/v1beta9/config.go:316:	// RemoteManifests lists Kubernetes manifests in remote clusters.
.//pkg/skaffold/schema/v1beta9/config.go:317:	RemoteManifests []string `yaml:"remoteManifests,omitempty"`
.//pkg/skaffold/schema/v1beta8/config.go:338:	// RemoteManifests lists Kubernetes manifests in remote clusters.
.//pkg/skaffold/schema/v1beta8/config.go:339:	RemoteManifests []string `yaml:"remoteManifests,omitempty"`
.//pkg/skaffold/schema/v1beta6/config.go:321:	// RemoteManifests lists Kubernetes manifests in remote clusters.
.//pkg/skaffold/schema/v1beta6/config.go:322:	RemoteManifests []string `yaml:"remoteManifests,omitempty"`
.//pkg/skaffold/schema/v1beta1/config.go:155:	RemoteManifests []string     `yaml:"remoteManifests,omitempty"`
.//pkg/skaffold/schema/v1alpha1/upgrade.go:33://  - KubectlDeploy.RemoteManifests, Flags - KubectlFlags type

The code reading remote manifest was present in the v0.21.0 but disappear in the v0.22.0.

It seems to come from this PR : https://github.com/GoogleContainerTools/skaffold/pull/1451/files

@dgageot dgageot added deploy/kubectl kind/bug Something isn't working labels Jun 26, 2019
@dgageot dgageot self-assigned this Jun 26, 2019
@dgageot
Copy link
Contributor

dgageot commented Jun 26, 2019

@seblegall Thank you for digging. I'm taking a look at it right now

@dgageot
Copy link
Contributor

dgageot commented Jun 26, 2019

So, it looks like those are two different issues. I'm going to create one to bring back the remoteManifests

@dgageot
Copy link
Contributor

dgageot commented Jun 26, 2019

see #2346

dgageot added a commit to dgageot/skaffold that referenced this issue Jun 26, 2019
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 26, 2019
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 27, 2019
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 27, 2019
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 27, 2019
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 28, 2019
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 28, 2019
dgageot added a commit to dgageot/skaffold that referenced this issue Jul 1, 2019
dgageot added a commit to dgageot/skaffold that referenced this issue Jul 1, 2019
@RakhiModi
Copy link

I am not using remote manifests, but still getting the same error.

@ghost ghost changed the title kubectl deploy URL manifests not working as expected remove May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy/kubectl kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants