Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for URL manifests #2348

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Fix support for URL manifests #2348

merged 1 commit into from
Jul 1, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jun 26, 2019

Fix #2322

Signed-off-by: David Gageot [email protected]

@codecov
Copy link

codecov bot commented Jun 26, 2019 •
edited
Loading

Codecov Report

Merging #2348 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/kubectl.go 71.95% <100%> (+2.61%) ⬆️

@dgageot dgageot force-pushed the kubectl-http branch 7 times, most recently from b4174fa to c790689 Compare July 1, 2019 13:59
@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Jul 1, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jul 1, 2019
nkubala
nkubala approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1 for the test

@balopat balopat merged commit 227fe48 into GoogleContainerTools:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala approved these changes

@balopat balopat Awaiting requested review from balopat

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove
5 participants
@dgageot @nkubala @balopat @googlebot @kokoro-team