Simplify Golang images #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
simonz130
suggested changes
Aug 18, 2020
| COPY index.html /app/index.html | ||
| COPY assets /app/assets/ | ||
|
|
||
| ENTRYPOINT ["/app/server"] |
There was a problem hiding this comment.
Why do we change the entrypoint from /app to /app/server?
There was a problem hiding this comment.
It felt wrong to be copying index.html and assets into the root. It also seemed weird to have /app/app.
There was a problem hiding this comment.
I'm more than happy to change /app/server to something else. /deploy/app?
There was a problem hiding this comment.
I changed this to /hello-world and kept the binary as app.
There was a problem hiding this comment.
LGTM - @simonz130 any additional feedback?
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
simonz130
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Cloud Code for VS Code now leverages
skaffold debugunder the hood, this PR re-proposes #102 with some slight updates.GOTRACEBACKenv var so skaffold debug can identify images as golang (as per Add environment variable to better support skaffold debug #259)SKAFFOLD_GO_GCFLAGSto use mode-specific compiler flags, like to disable optimization when usingskaffold debug.SKAFFOLD_GO_GCFLAGSto be ignored by the Go compiler. This bug does not break Skaffold 1.14 (current version distributed by Cloud SDK).