Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Golang images #102

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Conversation

briandealwis
Copy link
Member

  • Add GOTRACEBACK env var so skaffold debug can identify images as golang
  • Use multi-stage builds to produce smaller images (as [per distroless[(https://github.com/GoogleContainerTools/distroless#examples-with-docker))

Use multi-stage builds to produce smaller images.
@simonz130 simonz130 merged commit 755514c into GoogleCloudPlatform:master Oct 3, 2019
Copy link
Contributor

@sujit-kamireddy sujit-kamireddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@briandealwis ,
Is having "ENV GOTRACEBACK=all" mandatory for Go Dockerfile?
Or are we adding it primarily for 'skaffold debug'?

My concern is that skaffold debug may not work for existing apps that doesn't have this env var. Should we fix skaffold debug instead to support such cases?

@briandealwis
Copy link
Member Author

We need some way to identify the language runtime. There’s an open issue about defining an explicit mechanism (GoogleContainerTools/skaffold#2203), but this implicit environment approach is effective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants