Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't single-quote SKAFFOLD_GO_GCFLAGS #4864

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

briandealwis
Copy link
Member

Fixes: #4863
Related to: #4606

Description
We can't wrap the SKAFFOLD_GO_GCFLAGS value in single-quotes. Although the compiler doesn't complain, it doesn't apply the flags and so we end up with:

(dlv) c
> main.hello() /workspace/main.go:17 (hits goroutine(20):1 total:1) (PC: 0x66074d)
Warning: debugging optimized function

Verified with Docker and Buildpacks builder.

User facing changes (remove if N/A)

  • SKAFFOLD_GO_GCFLAGS is now properly quoted

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@3c10069). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4864   +/-   ##
=========================================
  Coverage          ?   71.86%           
=========================================
  Files             ?      356           
  Lines             ?    12218           
  Branches          ?        0           
=========================================
  Hits              ?     8780           
  Misses            ?     2786           
  Partials          ?      652           
Impacted Files Coverage Δ
pkg/skaffold/build/buildpacks/default_args.go 100.00% <ø> (ø)
pkg/skaffold/docker/build_args.go 66.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c10069...984ed1d. Read the comment docs.

@gsquared94
Copy link
Contributor

tagging @nkubala for #4467 (comment)

@briandealwis
Copy link
Member Author

We do add environment variables elsewhere in that example for skaffold debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SKAFFOLD_GO_GCFLAGS should not be quoted
3 participants