-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding node 18.x support #1266
base: dev
Are you sure you want to change the base?
Adding node 18.x support #1266
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@jakearchibald Sorry for the ping, you seem to be the last person who has contributed to this repo. Is this repo still maintained? If so, is someone able to help out with this PR and the related issue #1242? |
@devinmatte is this the only required thing? I'm getting these errors if I ignore the engine:
|
Looks like there's more to it. The issue is with the fetch API in node 18 it seems: node-fetch/node-fetch#1566 I can dive deeper into this, but looks like it's affecting a lot of projects, including another google repo google/draco#888 |
Yeah I assumed as much. Though looks like this is abandoned. Are there any good alternatives? |
fwiw, my plan is to deprecate this (just the CLI/lib, not the site), since there isn't anyone to work on it, and no chance to hire people to work on it given the current economic climate. Folks are welcome to continue the work in a fork. |
Fixes #1242
Node 18 is out, and the engine restrictions currently prevent it working on node 18. This simply adds node 18.x to the supported engines list