Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add timeout to github test action #345

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

RAX7
Copy link
Contributor

@RAX7 RAX7 commented Sep 9, 2022

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Sometimes the time of test actions takes up to 6 hours on windows. https://github.com/webpack-contrib/image-minimizer-webpack-plugin/actions/runs/3008820772/usage

It might be better to limit to 10 minutes.

Sometimes the time of test actions takes up to 6 hours on windows.
https://github.com/webpack-contrib/image-minimizer-webpack-plugin/actions/runs/3008820772/usage

It might be better to limit to 10 minutes.
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Base: 87.73% // Head: 87.73% // No change to project coverage 👍

Coverage data is based on head (b27f648) compared to base (146b612).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage   87.73%   87.73%           
=======================================
  Files           4        4           
  Lines         644      644           
  Branches      242      242           
=======================================
  Hits          565      565           
  Misses         71       71           
  Partials        8        8           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait
Copy link
Member

Maybe we should disable squoosh testing on windows (it is really buggy)

@alexander-akait alexander-akait merged commit 667863d into webpack-contrib:master Sep 9, 2022
@RAX7 RAX7 deleted the timeout-test-task branch September 9, 2022 14:59
@RAX7
Copy link
Contributor Author

RAX7 commented Sep 9, 2022

Yes, a good idea, because tests on windows always fail. And no hope of change, one of the squoosh developers said he plans to deprecate lib.
GoogleChromeLabs/squoosh#1266 (comment)

@alexander-akait
Copy link
Member

Yeah, let's disable it for window and disable it for node 18 too (because it is broken), need smll changes in tests, but should be easy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants